Skip to content

Next Page button triggered when filtering Customer grid #17789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lucasjor-summa opened this issue Aug 24, 2018 · 5 comments
Closed

Next Page button triggered when filtering Customer grid #17789

lucasjor-summa opened this issue Aug 24, 2018 · 5 comments
Labels
Component: Framework/Filter Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@lucasjor-summa
Copy link

Preconditions

  1. Magento 2.2.2
  2. 20+ customers created in order to have many pages in Customer grid

Steps to reproduce

  1. Go to "Sales -> Orders"
  2. "Create new order"
  3. Customer grid is displayed
  4. Focus on any column filter (i.e. text box in email column)
  5. Press ENTER to trigger the filter

Expected result

  1. Filter's AJAX call is triggered
  2. Results don't change because the filter input was empty
  3. Grid is still showing the same page.

Actual result

  1. Filter's AJAX call is triggered
  2. Next Page AJAX call is triggered at the same time (see screenshots)
  3. Results don't change because the filter input was empty
  4. Grid is showing the next page now
    screenshot from 2018-08-24 10 23 48
    screenshot from 2018-08-24 10 23 28
@magento-engcom-team
Copy link
Contributor

Hi @lucasjor-summa. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me {$VERSION} instance

where {$VERSION} is version tags (starting from 2.2.0+) or develop branches (2.2-develop +).
For more details, please, review the Magento Contributor Assistant documentation.

@lucasjor-summa do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Aug 24, 2018
@lucasjor-summa
Copy link
Author

I confirm that I was able to reproduce the issue on vanilla Magento 2.2.2 CE

@ghost ghost self-assigned this Aug 27, 2018
@ghost ghost added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Component: Framework/Filter Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development labels Aug 27, 2018
@ghost
Copy link

ghost commented Aug 27, 2018

@lucasjor-summa , thank you for your report.
We've acknowledged the issue and added to our backlog.

@ghost ghost removed their assignment Aug 27, 2018
This was referenced Aug 30, 2018
Merged
Merged
@magento-engcom-team
Copy link
Contributor

Hi @lucasjor-summa. Thank you for your report.
The issue has been fixed in #17870 by @ronak2ram in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.7 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Sep 5, 2018
@ishakhsuvarov
Copy link
Contributor

Hi @lucasjor-summa. Thank you for your report.
The issue has been fixed in #17874 by @ronak2ram in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

@ishakhsuvarov ishakhsuvarov added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Framework/Filter Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ishakhsuvarov @lucasjor-summa @magento-engcom-team