Skip to content

Catalogsearch Reindex #19982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vincent2090311 opened this issue Dec 27, 2018 · 9 comments
Closed

Catalogsearch Reindex #19982

vincent2090311 opened this issue Dec 27, 2018 · 9 comments
Assignees
Labels
Component: CatalogSearch Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release

Comments

@vincent2090311
Copy link

vincent2090311 commented Dec 27, 2018

Preconditions (*)

  1. Magento 2.2.7

Steps to reproduce (*)

  1. in this file vendor/magento/module-catalog-search/etc/indexer.xml has 2 classes
    <saveHandler class="Magento\CatalogSearch\Model\Indexer\IndexHandler" /> <structure class="Magento\CatalogSearch\Model\Indexer\IndexStructure" />
    I dont see those classes in magento, beside that, I found 2 classes
    Magento\CatalogSearch\Model\Indexer\IndexerHandler and Magento\CatalogSearch\Model\Indexer\IndexStructure

Is there anything wrong in define indexer

Expected result (*)

  1. The classes defined in xml should be existed

Actual result (*)

  1. Classes defined in xml not found
@magento-engcom-team
Copy link
Contributor

Hi @vincent2090311. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop).
For more details, please, review the Magento Contributor Assistant documentation.

@vincent2090311 do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Dec 27, 2018
@GovindaSharma GovindaSharma self-assigned this Dec 27, 2018
@magento-engcom-team
Copy link
Contributor

Hi @GovindaSharma. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@GovindaSharma
Copy link
Contributor

@vincent2090311 can you please elaborate your issue?

@vincent2090311
Copy link
Author

vincent2090311 commented Dec 27, 2018

@GovindaSharma
It isn't actually an issue (or I haven't look into the flow to check so I don't know there is any issue). I just dont understand why they put wrong class name into indexer.xml.

@dmytro-ch dmytro-ch added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Component: CatalogSearch labels Dec 27, 2018
@magento-engcom-team
Copy link
Contributor

@dmytro-ch Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-97348 were created

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Dec 27, 2018
@dmytro-ch
Copy link
Contributor

@vincent2090311, thank you for the report.
This issue has been already fixed for 2.3.x version by the following PR: #11626.
I think we just need to create backport for 2.2.x.

@magento-engcom-team
Copy link
Contributor

Hi @engcom-backlog-andrii. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if your want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

@ghost ghost added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Dec 27, 2018
@ghost
Copy link

ghost commented Dec 27, 2018

Closing as fixed #11626

@ghost ghost closed this as completed Dec 27, 2018
@ghost ghost removed their assignment Jan 9, 2019
@magento-engcom-team
Copy link
Contributor

Hi @vincent2090311. Thank you for your report.
The issue has been fixed in #19984 by @dmytro-ch in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.8 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Jan 21, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: CatalogSearch Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release
Projects
None yet
Development

No branches or pull requests

4 participants