Skip to content

Line length is too long in emails #24531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
philippeaellig opened this issue Sep 9, 2019 · 5 comments
Closed

Line length is too long in emails #24531

philippeaellig opened this issue Sep 9, 2019 · 5 comments
Assignees
Labels
Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed

Comments

@philippeaellig
Copy link

philippeaellig commented Sep 9, 2019

Preconditions (*)

Magento 2.2.8 in production mode. Use production mode to reproduce this bug, because only in this case, less code will compiled and minimized to one line.

Steps to reproduce (*)

Send an email with the default magento header.
vendor/magento/module-email/view/frontend/email/header.html
Have a look at the source code of the mail.
The line with the rendered css from css/email.css is too long, in my case 5611 octets. this is too long. allowed are max. 998 characters for one line. some mails will not reach the reciver, because some mailservers do not accept mails with long lines.

Expected result (*)

  1. minimizes css, but not in one line. no line longer than 998 characters.

Actual result (*)

  1. one line, 5611 characters.

I think, this issue is about the same topic. https://github.com/mageplaza/magento-2-smtp/issues/156 (another magento extension, but this is not a mageplaza bug...)

@m2-assistant
Copy link

m2-assistant bot commented Sep 9, 2019

Hi @philippeaellig. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@philippeaellig do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Sep 9, 2019
@edenduong edenduong self-assigned this Sep 9, 2019
@m2-assistant
Copy link

m2-assistant bot commented Sep 9, 2019

Hi @edenduong. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!


@engcom-Bravo engcom-Bravo self-assigned this Sep 9, 2019
@m2-assistant
Copy link

m2-assistant bot commented Sep 9, 2019

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@gwharton
Copy link
Contributor

gwharton commented Sep 10, 2019

Fixed in 2.2-develop. Will be in 2.2.10 release

@gwharton
Copy link
Contributor

See PR #23650

@engcom-Bravo engcom-Bravo removed their assignment Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed
Projects
None yet
Development

No branches or pull requests

5 participants