Skip to content

[Issue] Removed unused construct parameters #29531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
m2-assistant bot opened this issue Aug 13, 2020 · 3 comments · Fixed by #28653
Closed

[Issue] Removed unused construct parameters #29531

m2-assistant bot opened this issue Aug 13, 2020 · 3 comments · Fixed by #28653
Assignees
@Usik2203
Labels
Component: AdvancedPricingImportExport Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.

Comments

@m2-assistant
Copy link

m2-assistant bot commented Aug 13, 2020 •
edited by engcom-Delta
Loading

This issue is automatically created based on existing pull request: #28653: Removed unused construct parameters

Description (*)

This PR removes some unused parameters in construct of the class

Expected behavior (*)

Benefits

Additional information
@Usik2203 Usik2203 mentioned this issue Aug 13, 2020
Merged
1 task
@ghost ghost assigned Usik2203 Aug 13, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Aug 13, 2020
@ghost ghost added Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: PR in progress and removed Progress: ready for QA labels Aug 13, 2020
@magento-engcom-team magento-engcom-team added Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Sep 7, 2020
@engcom-Delta engcom-Delta added the Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch label Sep 7, 2020
@engcom-Delta engcom-Delta self-assigned this Sep 7, 2020
@m2-assistant
Copy link
Author

m2-assistant bot commented Sep 7, 2020

Hi @engcom-Delta. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Delta engcom-Delta added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Sep 7, 2020
@ghost ghost unassigned engcom-Delta Sep 7, 2020
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Sep 7, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Delta
Thank you for verifying the issue. Based on the provided information internal tickets MC-37424 were created

Issue Available: @engcom-Delta, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@sivaschenko
Copy link
Member

Hi @m2-assistant[bot]. Thank you for your report.
The issue has been fixed in #28653 by @Usik2203 in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.2 release.

@sivaschenko sivaschenko added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Sep 7, 2020
@sdzhepa sdzhepa mentioned this issue May 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Usik2203 Usik2203

Labels
Component: AdvancedPricingImportExport Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed unused construct parameters Usik2203/magento2
4 participants
@sivaschenko @Usik2203 @magento-engcom-team @engcom-Delta