Skip to content

Grid UI component performance and behavior #34225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 5 tasks
onlinebizsoft opened this issue Oct 2, 2021 · 13 comments
Closed
1 of 5 tasks

Grid UI component performance and behavior #34225

onlinebizsoft opened this issue Oct 2, 2021 · 13 comments
Assignees
Labels
Area: Performance Component: Catalog Issue: needs update Additional information is require, waiting for response Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it

Comments

@onlinebizsoft
Copy link

Summary (*)

I have watched on some performance monitoring tool and I found this bad behavior, lets say if you have a grid with some kind of sub-queries for each row (custom renderer for each cell for example) then you would see the problem very clearly.

Basically the Grid UI component are loading in 2 stages: first the page loaded from the controller on the GET request then sub-request from Ajax render the grid (mui render). However both seems to process the actual data so users have to wait twice time than normally

Examples (*)

image

image

Proposed solution

If on the first loading, we already have data then we could render it from server-side ready, if not then we should load the page fast without processing actual data then let the client-side render it with sub-request ajax (mui render)


Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

  • Severity: S0 - Affects critical data or functionality and leaves users with no workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@onlinebizsoft onlinebizsoft added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Oct 2, 2021
@m2-assistant
Copy link

m2-assistant bot commented Oct 2, 2021

Hi @onlinebizsoft. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@onlinebizsoft onlinebizsoft changed the title Grid UI performance and behavior Grid UI component performance and behavior Oct 2, 2021
@engcom-Hotel
Copy link
Contributor

Hi @onlinebizsoft.

Thank you for your report.

To help us process this issue please provide us the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

It would be good if you provide some screenshots as well related to the issue.

Thanks

@engcom-Hotel engcom-Hotel self-assigned this Oct 8, 2021
@m2-assistant
Copy link

m2-assistant bot commented Oct 8, 2021

Hi @engcom-Hotel. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Hotel engcom-Hotel added the Issue: needs update Additional information is require, waiting for response label Oct 8, 2021
@onlinebizsoft
Copy link
Author

@engcom-Hotel I have provided all these information.

@pemann
Copy link

pemann commented Oct 8, 2021

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @pemann. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

@pemann
Copy link

pemann commented Oct 8, 2021

This might be duplicate to magento/community-features#238

@onlinebizsoft
Copy link
Author

I consider this as a bug so it is not a feature request from the community.

@engcom-Hotel engcom-Hotel added Issue: ready for confirmation and removed Issue: needs update Additional information is require, waiting for response labels Feb 24, 2025
@github-project-automation github-project-automation bot moved this to Ready for Confirmation in Issue Confirmation and Triage Board Feb 24, 2025
@engcom-Hotel
Copy link
Contributor

Hello @onlinebizsoft,

Thanks for reopening the issue!

Are the steps to reproduce is same as mentioned here magento/community-features#238 (comment)?

And also which tool you have used to monitor the performance?

Thanks

@onlinebizsoft
Copy link
Author

Hello @onlinebizsoft,

Thanks for reopening the issue!

Are the steps to reproduce is same as mentioned here magento/community-features#238 (comment)?

And also which tool you have used to monitor the performance?

Thanks

@engcom-Hotel we use Tideways, you can also easily see with network request in the browser developer tool.

@engcom-Hotel
Copy link
Contributor

Hello @onlinebizsoft,

Thank you for your reply!

Since the issue is quite old, it might have been resolved along with other issues. We request you to try reproducing it in the latest 2.4-develop branch and let us know if the issue is still reproducible for you. Additionally, please confirm the steps to reproduce this issue.

Thanks

@engcom-Hotel
Copy link
Contributor

Hello @onlinebizsoft ,

As we have not heard from you regarding this issue for some time, we are assuming that it has been resolved. Therefore, we will be closing this issue.

If you are still experiencing any problems, please let us know.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Performance Component: Catalog Issue: needs update Additional information is require, waiting for response Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
None yet
Development

No branches or pull requests

3 participants