Skip to content

Cannot return null for non-nullable field \"AppliedCoupon.code\" unexpected issue #39841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
1 of 5 tasks
Dnd-Mafer opened this issue Apr 18, 2025 · 7 comments · May be fixed by #39842
Open
1 of 5 tasks

Cannot return null for non-nullable field \"AppliedCoupon.code\" unexpected issue #39841

Dnd-Mafer opened this issue Apr 18, 2025 · 7 comments · May be fixed by #39842
Assignees
@Dnd-Mafer
Labels
Area: Order Component: GraphQL GraphQL Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for grooming Reported on 2.4.8 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@Dnd-Mafer
Copy link

Dnd-Mafer commented Apr 18, 2025 •
edited
Loading

Preconditions and environment

Magento 2.4.8

Steps to reproduce

  • Create a salesrule with a specific coupon code available for everyone with a discount amount
  • Create a quote
  • Apply this coupon
  • Place the order
  • Get the order using GraphQL with the "applied_coupons.code" node
query getOrderByNumber($orderNumber: String!) {
  customer {
    orders(filter: { number: { eq: $orderNumber } }) {
      items {
        orderNumber: number
        applied_coupons {
          code
        }
      }
    }
  }
}

Expected result

{
  "data": {
    "customer": {
      "orders": {
        "items": [
          {
            "orderNumber": "000000003",
            "applied_coupons": [
              {
                "code": "h20"
              }
            ]
          }
        ]
      }
    }
  }
}

Actual result

{
  "errors": [
    {
      "message": "Internal server error",
      "locations": [
        {
          "line": 7,
          "column": 11
        }
      ],
      "path": [
        "customer",
        "orders",
        "items",
        0,
        "applied_coupons",
        0,
        "code"
      ],
      "extensions": {
        "debugMessage": "Cannot return null for non-nullable field \"AppliedCoupon.code\"."
      }
    }
  ],
  "data": {
    "customer": {
      "orders": {
        "items": [
          {
            "orderNumber": "000000003",
            "applied_coupons": [
              null
            ]
          }
        ]
      }
    }
  }
}

Additional information

Because of \Magento\SalesGraphQl\Model\Formatter\Order::format()

'applied_coupons' => $orderModel->getCouponCode() ? ['code' => $orderModel->getCouponCode()] : []

This should be encapsulate in an array

'applied_coupons' => $orderModel->getCouponCode() ? [['code' => $orderModel->getCouponCode()]] : [],

Release note

GraphQL - fix issue while getting applied_coupons.code on order

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Apr 18, 2025

Hi @Dnd-Mafer. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

@github-project-automation github-project-automation bot moved this to Ready for Confirmation in Issue Confirmation and Triage Board Apr 18, 2025
@Dnd-Mafer
Copy link
Author

@magento I am working on this

@engcom-Bravo engcom-Bravo self-assigned this Apr 18, 2025
@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Apr 18, 2025

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Bravo engcom-Bravo added the Reported on 2.4.8 Indicates original Magento version for the Issue report. label Apr 18, 2025
@engcom-Bravo
Copy link
Contributor

Hi @Dnd-Mafer,

Thanks for your reporting and collaboration.

We have tried to reproduce the issue in latest 2.4-develop and 2.4.8 instance and we are able to reproduce the issue.Kindly refer the screenshots.

2.4.8

Image

2.4-develop

Image

Hence Confirming the issue.

Thanks.

@engcom-Bravo engcom-Bravo added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Component: GraphQL GraphQL Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Area: Order labels Apr 22, 2025
@ct-prd-projects-boards-automation ct-prd-projects-boards-automation bot moved this from Ready for Confirmation to Confirmed in Issue Confirmation and Triage Board Apr 22, 2025
@ct-prd-projects-boards-automation ct-prd-projects-boards-automation bot moved this to Ready for Development in High Priority Backlog Apr 22, 2025
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-14484 is successfully created for this GitHub issue.

@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Apr 22, 2025

✅ Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@engcom-Hotel engcom-Hotel linked a pull request Apr 22, 2025 that will close this issue
Fix "Cannot return null for non-nullable field \"AppliedCoupon.code\"" error #39842
Open
5 tasks
@engcom-Bravo
Copy link
Contributor

Hi @Dnd-Mafer,

Adobe Commerce Engineering team started working on this issue. We will reach out to you if we need more information and you will get notified once the issue is fixed. Please leave comments for any further questions.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dnd-Mafer Dnd-Mafer

Labels
Area: Order Component: GraphQL GraphQL Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for grooming Reported on 2.4.8 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
High Priority Backlog
Status: Ready for Development
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix "Cannot return null for non-nullable field \"AppliedCoupon.code\"" error Agence-DnD/magento2
3 participants
@Dnd-Mafer @engcom-Bravo @github-jira-sync-bot