Skip to content

Bundle option id changes every time when editing on admin page #9546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NisaKH opened this issue May 8, 2017 · 13 comments
Closed

Bundle option id changes every time when editing on admin page #9546

NisaKH opened this issue May 8, 2017 · 13 comments
Labels
bug report Component: Catalog Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: needs update

Comments

@NisaKH
Copy link

NisaKH commented May 8, 2017

Bundle option id changes every time when editing on admin page

Preconditions

  1. Version 2.1.5

Steps to reproduce

  1. create bundle product with some options -> save product
  2. click save button again then

Expected result

  1. the product is updated and the bundle option ids does not change.

Actual result

  1. the bundle option ids are recreated every time the product is saved.
@tony831993
Copy link

Having same issue the options are duplicated after save product.... looking for some fix regarding this........

@yourasheesh
Copy link

yourasheesh commented May 10, 2017

Version: Magento CE 2.1.6
Same issue

@feronera
Copy link

2.1.5 CE too

@miro91
Copy link

miro91 commented May 13, 2017

I also have this issue with drop-down options
Magento CE 2.1.5

@sheldmandu
Copy link

This is a major issue for anyone doing any kind of integration or relying on Reorder functionality as it also breaks re-order functionality. Is there any ETA on this getting fixed. Can someone from Magento acknowledge this issue. It's the same issue as for custom options on simple products.

@Stas94
Copy link

Stas94 commented Jun 26, 2017

@NisaKH We cannot reproduce this issue as described. Please provide the detailed steps we must follow to reproduce this issue. In addition, identify the web server you are running, the versions of PHP and MySQL, and any other information needed to reproduce your issue.

@miro91
Copy link

miro91 commented Jun 27, 2017

@Stas94 I can reproduce the issue with PHP 7.0.15 and 7.0.16.
To reproduce the issue see records in catalog_product_bundle_selection table and choose some product_id. Then open to edit that product and just save it.
Now refresh catalog_product_bundle_selection table and see how the entities have new selection_id values.
It's the same for custom options.

@Stas94
Copy link

Stas94 commented Jun 27, 2017

@NisaKH , @miro91 Thanks for reporting this issue. We've created internal ticket MAGETWO-70276 to address this issue.

@veloraven veloraven added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Jun 27, 2017
@MagePsycho
Copy link
Contributor

This is a weird issue happening in Magento EE 2.1.1 also. This will create an issue if your product page is cached in the storefront and you update the bundle in the backend.

Delete and Insert of options is happening in the class: vendor/magento/module-bundle/Model/Product/SaveHandler.php::execute()

foreach ($this->optionRepository->getList($entity->getSku()) as $option) {
    $this->removeOptionLinks($entity->getSku(), $option);
    $this->optionRepository->delete($option);
}

Not sure removing this should work without side-effects. Gonna investigate more and update here.

@PascalBrouwers
Copy link
Contributor

And because of this there is a related issue: #5192

@PascalBrouwers
Copy link
Contributor

Apparently going to be fixed in 2.2 : f19ea67

Anyone willing to make a 2.1 version?

@miro91
Copy link

miro91 commented Aug 4, 2017

@PascalBrouwers I can confirm that it's fixed in 2.2.0
Maybe we will need to wait for the official release of 2.2 which is expected to be end of this month or beginning of September which is not too bad

@magento-engcom-team magento-engcom-team added 2.1.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report Component: Catalog Progress: needs update Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed G1 Passed labels Sep 5, 2017
@LovelySetia
Copy link

LovelySetia commented Aug 29, 2018

I have Same issue in Magento-2.1.12-CE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Component: Catalog Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: needs update
Projects
None yet
Development

No branches or pull requests