From 3409af0c89d202ba48ce017d1cb38e57ece5b5f5 Mon Sep 17 00:00:00 2001 From: Barny Shergold Date: Wed, 10 Jun 2020 23:25:35 +0100 Subject: [PATCH 01/10] Changed so that store view category is always used to create product URLs --- .../Model/ProductScopeRewriteGenerator.php | 28 ++----------------- .../ProductScopeRewriteGeneratorTest.php | 11 +++++++- 2 files changed, 13 insertions(+), 26 deletions(-) diff --git a/app/code/Magento/CatalogUrlRewrite/Model/ProductScopeRewriteGenerator.php b/app/code/Magento/CatalogUrlRewrite/Model/ProductScopeRewriteGenerator.php index 9d26184e2c2d4..693084b7aba18 100644 --- a/app/code/Magento/CatalogUrlRewrite/Model/ProductScopeRewriteGenerator.php +++ b/app/code/Magento/CatalogUrlRewrite/Model/ProductScopeRewriteGenerator.php @@ -174,8 +174,9 @@ public function generateForSpecificStoreView($storeId, $productCategories, Produ continue; } - // category should be loaded per appropriate store if category's URL key has been changed - $categories[] = $this->getCategoryWithOverriddenUrlKey($storeId, $category); + // Category should be loaded per appropriate store at all times. This is because whilst the URL key on the + // category in focus might be unchanged, parent category URL keys might be + $categories[] = $this->categoryRepository->get($category->getEntityId(), $storeId); } $productCategories = $this->objectRegistryFactory->create(['entities' => $categories]); @@ -234,29 +235,6 @@ public function isCategoryProperForGenerating(Category $category, $storeId) return false; } - /** - * Check if URL key has been changed - * - * Checks if URL key has been changed for provided category and returns reloaded category, - * in other case - returns provided category. - * - * @param int $storeId - * @param Category $category - * @return Category - */ - private function getCategoryWithOverriddenUrlKey($storeId, Category $category) - { - $isUrlKeyOverridden = $this->storeViewService->doesEntityHaveOverriddenUrlKeyForStore( - $storeId, - $category->getEntityId(), - Category::ENTITY - ); - - if (!$isUrlKeyOverridden) { - return $category; - } - return $this->categoryRepository->get($category->getEntityId(), $storeId); - } /** * Check config value of generate_category_product_rewrites diff --git a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/ProductScopeRewriteGeneratorTest.php b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/ProductScopeRewriteGeneratorTest.php index 7b18461a580fe..f54805158cfb2 100644 --- a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/ProductScopeRewriteGeneratorTest.php +++ b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/ProductScopeRewriteGeneratorTest.php @@ -7,6 +7,7 @@ namespace Magento\CatalogUrlRewrite\Test\Unit\Model; +use Magento\Catalog\Api\CategoryRepositoryInterface; use Magento\Catalog\Model\Category; use Magento\Catalog\Model\Product; use Magento\CatalogUrlRewrite\Model\ObjectRegistry; @@ -69,6 +70,9 @@ class ProductScopeRewriteGeneratorTest extends TestCase /** @var ScopeConfigInterface|MockObject */ private $configMock; + /** @var CategoryRepositoryInterface|MockObject */ + private $categoryRepository; + protected function setUp(): void { $this->serializer = $this->createMock(Json::class); @@ -126,6 +130,8 @@ function ($value) { $this->configMock = $this->getMockBuilder(ScopeConfigInterface::class) ->getMock(); + $this->categoryRepository = $this->getMockForAbstractClass(CategoryRepositoryInterface::class); + $this->productScopeGenerator = (new ObjectManager($this))->getObject( ProductScopeRewriteGenerator::class, [ @@ -137,7 +143,8 @@ function ($value) { 'storeViewService' => $this->storeViewService, 'storeManager' => $this->storeManager, 'mergeDataProviderFactory' => $mergeDataProviderFactory, - 'config' => $this->configMock + 'config' => $this->configMock, + 'categoryRepository' => $this->categoryRepository ] ); $this->categoryMock = $this->getMockBuilder(Category::class) @@ -215,6 +222,8 @@ public function testGenerationForSpecificStore() $this->anchorUrlRewriteGenerator->expects($this->any())->method('generate') ->willReturn([]); + $this->categoryRepository->expects($this->once())->method('get')->willReturn($this->categoryMock); + $this->assertEquals( ['category-1_1' => $canonical], $this->productScopeGenerator->generateForSpecificStoreView(1, [$this->categoryMock], $product, 1) From a6d197634e84277ee375a5c9668395a18828b39e Mon Sep 17 00:00:00 2001 From: Barny Shergold Date: Thu, 11 Jun 2020 14:21:31 +0100 Subject: [PATCH 02/10] Correction from Code Sniffer --- .../CatalogUrlRewrite/Model/ProductScopeRewriteGenerator.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/code/Magento/CatalogUrlRewrite/Model/ProductScopeRewriteGenerator.php b/app/code/Magento/CatalogUrlRewrite/Model/ProductScopeRewriteGenerator.php index 693084b7aba18..02a00748442be 100644 --- a/app/code/Magento/CatalogUrlRewrite/Model/ProductScopeRewriteGenerator.php +++ b/app/code/Magento/CatalogUrlRewrite/Model/ProductScopeRewriteGenerator.php @@ -21,6 +21,9 @@ /** * Class ProductScopeRewriteGenerator + * + * Generates Product/Category URLs for different scopes + * * @SuppressWarnings(PHPMD.CouplingBetweenObjects) */ class ProductScopeRewriteGenerator @@ -235,7 +238,6 @@ public function isCategoryProperForGenerating(Category $category, $storeId) return false; } - /** * Check config value of generate_category_product_rewrites * From ac1ac0632f8c7e9a93d25d5a498dbce1e2170c1d Mon Sep 17 00:00:00 2001 From: Barny Shergold Date: Mon, 22 Jun 2020 13:55:55 +0100 Subject: [PATCH 03/10] Corrected issue causing integration test to fail when category move is tested --- .../Model/CategoryUrlPathGenerator.php | 5 +-- .../Model/ProductScopeRewriteGenerator.php | 33 +++++++++++++++++-- 2 files changed, 31 insertions(+), 7 deletions(-) diff --git a/app/code/Magento/CatalogUrlRewrite/Model/CategoryUrlPathGenerator.php b/app/code/Magento/CatalogUrlRewrite/Model/CategoryUrlPathGenerator.php index cba9218ce7c72..118bd17ddd604 100644 --- a/app/code/Magento/CatalogUrlRewrite/Model/CategoryUrlPathGenerator.php +++ b/app/code/Magento/CatalogUrlRewrite/Model/CategoryUrlPathGenerator.php @@ -73,10 +73,7 @@ public function getUrlPath($category, $parentCategory = null) if (in_array($category->getParentId(), [Category::ROOT_CATEGORY_ID, Category::TREE_ROOT_ID])) { return ''; } - $path = $category->getUrlPath(); - if ($path !== null && !$category->dataHasChangedFor('url_key') && !$category->dataHasChangedFor('parent_id')) { - return $path; - } + $path = $category->getUrlKey(); if ($path === false) { return $category->getUrlPath(); diff --git a/app/code/Magento/CatalogUrlRewrite/Model/ProductScopeRewriteGenerator.php b/app/code/Magento/CatalogUrlRewrite/Model/ProductScopeRewriteGenerator.php index 02a00748442be..a958ad4db0c8f 100644 --- a/app/code/Magento/CatalogUrlRewrite/Model/ProductScopeRewriteGenerator.php +++ b/app/code/Magento/CatalogUrlRewrite/Model/ProductScopeRewriteGenerator.php @@ -177,9 +177,7 @@ public function generateForSpecificStoreView($storeId, $productCategories, Produ continue; } - // Category should be loaded per appropriate store at all times. This is because whilst the URL key on the - // category in focus might be unchanged, parent category URL keys might be - $categories[] = $this->categoryRepository->get($category->getEntityId(), $storeId); + $categories[] = $this->getCategoryWithOverriddenUrlKey($storeId, $category); } $productCategories = $this->objectRegistryFactory->create(['entities' => $categories]); @@ -238,6 +236,35 @@ public function isCategoryProperForGenerating(Category $category, $storeId) return false; } + /** + * Check if URL key has been changed + * + * Checks if URL key has been changed for provided category and returns reloaded category, + * in other case - returns provided category. + * + * @param int $storeId + * @param Category $category + * @return Category + */ + private function getCategoryWithOverriddenUrlKey($storeId, Category $category) + { + $isUrlKeyOverridden = $this->storeViewService->doesEntityHaveOverriddenUrlKeyForStore( + $storeId, + $category->getEntityId(), + Category::ENTITY + ); + + // Category should be loaded per appropriate store at all times. This is because whilst the URL key on the + // category in focus might be unchanged, parent category URL keys might be. If the category store ID + // and passed store ID are the same then return current category as it is correct but may have changed in memory + + if (!$isUrlKeyOverridden && $storeId == $category->getStoreId()) { + return $category; + } + + return $this->categoryRepository->get($category->getEntityId(), $storeId); + } + /** * Check config value of generate_category_product_rewrites * From e100822f5858d5c218cfb72a76478ff3db194a26 Mon Sep 17 00:00:00 2001 From: Barny Shergold Date: Mon, 22 Jun 2020 15:21:22 +0100 Subject: [PATCH 04/10] Reversed change --- .../CatalogUrlRewrite/Model/CategoryUrlPathGenerator.php | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/app/code/Magento/CatalogUrlRewrite/Model/CategoryUrlPathGenerator.php b/app/code/Magento/CatalogUrlRewrite/Model/CategoryUrlPathGenerator.php index 118bd17ddd604..cba9218ce7c72 100644 --- a/app/code/Magento/CatalogUrlRewrite/Model/CategoryUrlPathGenerator.php +++ b/app/code/Magento/CatalogUrlRewrite/Model/CategoryUrlPathGenerator.php @@ -73,7 +73,10 @@ public function getUrlPath($category, $parentCategory = null) if (in_array($category->getParentId(), [Category::ROOT_CATEGORY_ID, Category::TREE_ROOT_ID])) { return ''; } - + $path = $category->getUrlPath(); + if ($path !== null && !$category->dataHasChangedFor('url_key') && !$category->dataHasChangedFor('parent_id')) { + return $path; + } $path = $category->getUrlKey(); if ($path === false) { return $category->getUrlPath(); From d59d740c6d4424ca479a19581f1cfa56579e5096 Mon Sep 17 00:00:00 2001 From: Barny Shergold Date: Tue, 7 Jul 2020 22:32:18 +0100 Subject: [PATCH 05/10] Updated code as per reviewer --- .../Model/ProductScopeRewriteGenerator.php | 20 +++++++++---------- .../ProductScopeRewriteGeneratorTest.php | 8 ++++---- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/app/code/Magento/CatalogUrlRewrite/Model/ProductScopeRewriteGenerator.php b/app/code/Magento/CatalogUrlRewrite/Model/ProductScopeRewriteGenerator.php index a958ad4db0c8f..5879a62a85954 100644 --- a/app/code/Magento/CatalogUrlRewrite/Model/ProductScopeRewriteGenerator.php +++ b/app/code/Magento/CatalogUrlRewrite/Model/ProductScopeRewriteGenerator.php @@ -6,6 +6,7 @@ namespace Magento\CatalogUrlRewrite\Model; use Magento\Catalog\Api\CategoryRepositoryInterface; +use Magento\Catalog\Api\Data\CategoryInterface; use Magento\Catalog\Model\Category; use Magento\Catalog\Model\Product; use Magento\CatalogUrlRewrite\Model\Product\AnchorUrlRewriteGenerator; @@ -15,13 +16,12 @@ use Magento\CatalogUrlRewrite\Service\V1\StoreViewService; use Magento\Framework\App\Config\ScopeConfigInterface; use Magento\Framework\App\ObjectManager; +use Magento\Framework\Exception\NoSuchEntityException; use Magento\Store\Model\Store; use Magento\Store\Model\StoreManagerInterface; use Magento\UrlRewrite\Model\MergeDataProviderFactory; /** - * Class ProductScopeRewriteGenerator - * * Generates Product/Category URLs for different scopes * * @SuppressWarnings(PHPMD.CouplingBetweenObjects) @@ -237,14 +237,18 @@ public function isCategoryProperForGenerating(Category $category, $storeId) } /** - * Check if URL key has been changed - * * Checks if URL key has been changed for provided category and returns reloaded category, * in other case - returns provided category. * + * Category should be loaded per appropriate store at all times. This is because whilst the URL key on the + * category in focus might be unchanged, parent category URL keys might be. If the category store ID + * and passed store ID are the same then return current category as it is correct but may have changed in memory + * * @param int $storeId * @param Category $category - * @return Category + * + * @return CategoryInterface + * @throws NoSuchEntityException */ private function getCategoryWithOverriddenUrlKey($storeId, Category $category) { @@ -254,11 +258,7 @@ private function getCategoryWithOverriddenUrlKey($storeId, Category $category) Category::ENTITY ); - // Category should be loaded per appropriate store at all times. This is because whilst the URL key on the - // category in focus might be unchanged, parent category URL keys might be. If the category store ID - // and passed store ID are the same then return current category as it is correct but may have changed in memory - - if (!$isUrlKeyOverridden && $storeId == $category->getStoreId()) { + if (!$isUrlKeyOverridden && $storeId === $category->getStoreId()) { return $category; } diff --git a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/ProductScopeRewriteGeneratorTest.php b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/ProductScopeRewriteGeneratorTest.php index f54805158cfb2..d9c6adce9661f 100644 --- a/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/ProductScopeRewriteGeneratorTest.php +++ b/app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/ProductScopeRewriteGeneratorTest.php @@ -71,7 +71,7 @@ class ProductScopeRewriteGeneratorTest extends TestCase private $configMock; /** @var CategoryRepositoryInterface|MockObject */ - private $categoryRepository; + private $categoryRepositoryMock; protected function setUp(): void { @@ -130,7 +130,7 @@ function ($value) { $this->configMock = $this->getMockBuilder(ScopeConfigInterface::class) ->getMock(); - $this->categoryRepository = $this->getMockForAbstractClass(CategoryRepositoryInterface::class); + $this->categoryRepositoryMock = $this->getMockForAbstractClass(CategoryRepositoryInterface::class); $this->productScopeGenerator = (new ObjectManager($this))->getObject( ProductScopeRewriteGenerator::class, @@ -144,7 +144,7 @@ function ($value) { 'storeManager' => $this->storeManager, 'mergeDataProviderFactory' => $mergeDataProviderFactory, 'config' => $this->configMock, - 'categoryRepository' => $this->categoryRepository + 'categoryRepository' => $this->categoryRepositoryMock ] ); $this->categoryMock = $this->getMockBuilder(Category::class) @@ -222,7 +222,7 @@ public function testGenerationForSpecificStore() $this->anchorUrlRewriteGenerator->expects($this->any())->method('generate') ->willReturn([]); - $this->categoryRepository->expects($this->once())->method('get')->willReturn($this->categoryMock); + $this->categoryRepositoryMock->expects($this->once())->method('get')->willReturn($this->categoryMock); $this->assertEquals( ['category-1_1' => $canonical], From 009762500fc1a45f9deac4e2628bdfbcaf61c62c Mon Sep 17 00:00:00 2001 From: Barny Shergold Date: Wed, 8 Jul 2020 01:49:09 +0100 Subject: [PATCH 06/10] Updated code as per failed test --- .../CatalogUrlRewrite/Model/ProductScopeRewriteGenerator.php | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/app/code/Magento/CatalogUrlRewrite/Model/ProductScopeRewriteGenerator.php b/app/code/Magento/CatalogUrlRewrite/Model/ProductScopeRewriteGenerator.php index 5879a62a85954..cf01c825e9231 100644 --- a/app/code/Magento/CatalogUrlRewrite/Model/ProductScopeRewriteGenerator.php +++ b/app/code/Magento/CatalogUrlRewrite/Model/ProductScopeRewriteGenerator.php @@ -237,8 +237,7 @@ public function isCategoryProperForGenerating(Category $category, $storeId) } /** - * Checks if URL key has been changed for provided category and returns reloaded category, - * in other case - returns provided category. + * Checks if URL key has been changed for provided category and returns reloaded category in other case - returns provided category. * * Category should be loaded per appropriate store at all times. This is because whilst the URL key on the * category in focus might be unchanged, parent category URL keys might be. If the category store ID From 7ee8e09fdf8d2d88eca262688b5bf14170b124c6 Mon Sep 17 00:00:00 2001 From: Barny Shergold Date: Wed, 8 Jul 2020 09:42:42 +0100 Subject: [PATCH 07/10] Updated code as per failed test --- .../CatalogUrlRewrite/Model/ProductScopeRewriteGenerator.php | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/app/code/Magento/CatalogUrlRewrite/Model/ProductScopeRewriteGenerator.php b/app/code/Magento/CatalogUrlRewrite/Model/ProductScopeRewriteGenerator.php index cf01c825e9231..165f9c07127e7 100644 --- a/app/code/Magento/CatalogUrlRewrite/Model/ProductScopeRewriteGenerator.php +++ b/app/code/Magento/CatalogUrlRewrite/Model/ProductScopeRewriteGenerator.php @@ -237,8 +237,11 @@ public function isCategoryProperForGenerating(Category $category, $storeId) } /** - * Checks if URL key has been changed for provided category and returns reloaded category in other case - returns provided category. + * Check if URL key has been changed * + * Checks if URL key has been changed for provided category and returns reloaded category, + * in other case - returns provided category. + * * Category should be loaded per appropriate store at all times. This is because whilst the URL key on the * category in focus might be unchanged, parent category URL keys might be. If the category store ID * and passed store ID are the same then return current category as it is correct but may have changed in memory From 54457b42ba1c7304a794598b26cadd829fa6cbe0 Mon Sep 17 00:00:00 2001 From: Barny Shergold Date: Wed, 8 Jul 2020 10:23:05 +0100 Subject: [PATCH 08/10] Updated code as per failed test --- .../CatalogUrlRewrite/Model/ProductScopeRewriteGenerator.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/code/Magento/CatalogUrlRewrite/Model/ProductScopeRewriteGenerator.php b/app/code/Magento/CatalogUrlRewrite/Model/ProductScopeRewriteGenerator.php index 165f9c07127e7..7bf1da2b814e3 100644 --- a/app/code/Magento/CatalogUrlRewrite/Model/ProductScopeRewriteGenerator.php +++ b/app/code/Magento/CatalogUrlRewrite/Model/ProductScopeRewriteGenerator.php @@ -241,7 +241,7 @@ public function isCategoryProperForGenerating(Category $category, $storeId) * * Checks if URL key has been changed for provided category and returns reloaded category, * in other case - returns provided category. - * + * * Category should be loaded per appropriate store at all times. This is because whilst the URL key on the * category in focus might be unchanged, parent category URL keys might be. If the category store ID * and passed store ID are the same then return current category as it is correct but may have changed in memory From ec3e6da7b188cc5c88179d9aa89f698fafd345d2 Mon Sep 17 00:00:00 2001 From: engcom-Echo Date: Tue, 15 Sep 2020 16:22:51 +0300 Subject: [PATCH 09/10] add mftf test --- ...ntCategoryUrlRewriteDifferentStoreTest.xml | 79 +++++++++++++++++++ 1 file changed, 79 insertions(+) create mode 100644 app/code/Magento/CatalogUrlRewrite/Test/Mftf/Test/StorefrontCategoryUrlRewriteDifferentStoreTest.xml diff --git a/app/code/Magento/CatalogUrlRewrite/Test/Mftf/Test/StorefrontCategoryUrlRewriteDifferentStoreTest.xml b/app/code/Magento/CatalogUrlRewrite/Test/Mftf/Test/StorefrontCategoryUrlRewriteDifferentStoreTest.xml new file mode 100644 index 0000000000000..a79651a39cc37 --- /dev/null +++ b/app/code/Magento/CatalogUrlRewrite/Test/Mftf/Test/StorefrontCategoryUrlRewriteDifferentStoreTest.xml @@ -0,0 +1,79 @@ + + + + + + + + <description value="Verify url category for different store view, after change ukr_key category for one of them store view."/> + <features value="CatalogUrlRewrite"/> + <severity value="MAJOR"/> + </annotations> + <before> + <magentoCLI command="config:set catalog/seo/product_use_categories 1" stepKey="setEnableUseCategoriesPath"/> + <createData entity="SubCategory" stepKey="rootCategory"/> + <createData entity="SimpleSubCategoryDifferentUrlStore" stepKey="subCategory"> + <requiredEntity createDataKey="rootCategory"/> + </createData> + <createData entity="_defaultProduct" stepKey="createProduct"> + <requiredEntity createDataKey="subCategory"/> + </createData> + <actionGroup ref="AdminLoginActionGroup" stepKey="loginAsAdmin"/> + + <actionGroup ref="CreateStoreViewActionGroup" stepKey="createCustomStoreViewFr"> + <argument name="storeView" value="customStoreFR"/> + </actionGroup> + + <actionGroup ref="CliIndexerReindexActionGroup" stepKey="indexerReindexAfterCreate"> + <argument name="indices" value=""/> + </actionGroup> + <actionGroup ref="CliCacheFlushActionGroup" stepKey="flushCacheBefore"> + <argument name="tags" value=""/> + </actionGroup> + </before> + <after> + <magentoCLI command="config:set catalog/seo/product_use_categories 0" stepKey="setEnableUseCategoriesPath"/> + <deleteData stepKey="deleteProduct" createDataKey="createProduct"/> + <deleteData stepKey="deleteSubCategory" createDataKey="subCategory"/> + <deleteData stepKey="deleteRootCategory" createDataKey="rootCategory"/> + + <actionGroup ref="AdminDeleteStoreViewActionGroup" stepKey="deleteStoreView"> + <argument name="customStore" value="customStoreFR"/> + </actionGroup> + <actionGroup ref="AdminLogoutActionGroup" stepKey="logout"/> + </after> + + <actionGroup ref="NavigateToCreatedCategoryActionGroup" stepKey="navigateToCreatedSubCategory"> + <argument name="Category" value="$$subCategory$$"/> + </actionGroup> + <actionGroup ref="AdminSwitchStoreViewActionGroup" stepKey="AdminSwitchCustomStoreViewForSubCategory"> + <argument name="storeView" value="customStoreFR.name"/> + </actionGroup> + <actionGroup ref="ChangeSeoUrlKeyForSubCategoryActionGroup" stepKey="changeSeoUrlKeyForSubCategoryCustomStore"> + <argument name="value" value="{{SimpleSubCategoryDifferentUrlStore.url_key_custom_store}}"/> + </actionGroup> + + <actionGroup ref="StorefrontGoToSubCategoryPageActionGroup" stepKey="goToCategoryC"> + <argument name="categoryName" value="$$rootCategory.name$$"/> + <argument name="subCategoryName" value="$$subCategory.name$$"/> + </actionGroup> + + <click selector="{{StorefrontCategoryProductSection.ProductInfoByName($$createProduct.name$$)}}" stepKey="navigateToCreateProduct"/> + + <actionGroup ref="StorefrontSwitchStoreViewActionGroup" stepKey="switchStore"> + <argument name="storeView" value="customStoreFR" /> + </actionGroup> + + <grabFromCurrentUrl stepKey="grabUrl"/> + <assertStringContainsString stepKey="assertUrl"> + <expectedResult type="string">{{SimpleSubCategoryDifferentUrlStore.url_key_custom_store}}</expectedResult> + <actualResult type="string">{$grabUrl}</actualResult> + </assertStringContainsString> + </test> +</tests> From 4b9f004015721e0bb161fdc9f4b6d98120573185 Mon Sep 17 00:00:00 2001 From: engcom-Echo <engcom-vendorworker-echo@adobe.com> Date: Tue, 29 Sep 2020 12:39:37 +0300 Subject: [PATCH 10/10] update severity, added testCaseId --- .../Test/StorefrontCategoryUrlRewriteDifferentStoreTest.xml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/code/Magento/CatalogUrlRewrite/Test/Mftf/Test/StorefrontCategoryUrlRewriteDifferentStoreTest.xml b/app/code/Magento/CatalogUrlRewrite/Test/Mftf/Test/StorefrontCategoryUrlRewriteDifferentStoreTest.xml index a79651a39cc37..776b5b9b70f33 100644 --- a/app/code/Magento/CatalogUrlRewrite/Test/Mftf/Test/StorefrontCategoryUrlRewriteDifferentStoreTest.xml +++ b/app/code/Magento/CatalogUrlRewrite/Test/Mftf/Test/StorefrontCategoryUrlRewriteDifferentStoreTest.xml @@ -13,7 +13,8 @@ <title value="Verify url category for different store view."/> <description value="Verify url category for different store view, after change ukr_key category for one of them store view."/> <features value="CatalogUrlRewrite"/> - <severity value="MAJOR"/> + <severity value="AVERAGE"/> + <testCaseId value="MC-38053"/> </annotations> <before> <magentoCLI command="config:set catalog/seo/product_use_categories 1" stepKey="setEnableUseCategoriesPath"/>