diff --git a/app/code/Magento/Email/Block/Adminhtml/Template/Grid/Renderer/Action.php b/app/code/Magento/Email/Block/Adminhtml/Template/Grid/Renderer/Action.php index 65f9e41b074a3..3c009c47087e9 100644 --- a/app/code/Magento/Email/Block/Adminhtml/Template/Grid/Renderer/Action.php +++ b/app/code/Magento/Email/Block/Adminhtml/Template/Grid/Renderer/Action.php @@ -42,7 +42,7 @@ public function render(\Magento\Framework\DataObject $row) protected function _getEscapedValue($value) { // phpcs:ignore Magento2.Functions.DiscouragedFunction - return addcslashes($this->escapeHtml($value), '\\\''); + return addcslashes($this->_escaper->escapeHtml($value), '\\\''); } /** diff --git a/app/code/Magento/Email/Block/Adminhtml/Template/Grid/Renderer/Sender.php b/app/code/Magento/Email/Block/Adminhtml/Template/Grid/Renderer/Sender.php index 005d211a8962e..295284b8c4dd8 100644 --- a/app/code/Magento/Email/Block/Adminhtml/Template/Grid/Renderer/Sender.php +++ b/app/code/Magento/Email/Block/Adminhtml/Template/Grid/Renderer/Sender.php @@ -23,7 +23,7 @@ public function render(\Magento\Framework\DataObject $row) $str = ''; if ($row->getTemplateSenderName()) { - $str .= $this->escapeHtml($row->getTemplateSenderName()) . ' '; + $str .= $this->_escaper->escapeHtml($row->getTemplateSenderName()) . ' '; } if ($row->getTemplateSenderEmail()) { diff --git a/app/code/Magento/Email/Block/Adminhtml/Template/Preview.php b/app/code/Magento/Email/Block/Adminhtml/Template/Preview.php index 58fa4a1d318ff..f9c60950a4b15 100644 --- a/app/code/Magento/Email/Block/Adminhtml/Template/Preview.php +++ b/app/code/Magento/Email/Block/Adminhtml/Template/Preview.php @@ -81,7 +81,7 @@ protected function _toHtml() $templateProcessed = $this->_maliciousCode->filter($templateProcessed); if ($template->isPlain()) { - $templateProcessed = "
" . $this->escapeHtml($templateProcessed) . ""; + $templateProcessed = "
" . $this->_escaper->escapeHtml($templateProcessed) . ""; } \Magento\Framework\Profiler::stop($this->profilerName); diff --git a/app/code/Magento/Email/Test/Unit/Block/Adminhtml/Template/Render/SenderTest.php b/app/code/Magento/Email/Test/Unit/Block/Adminhtml/Template/Render/SenderTest.php index d81c70d7955ed..4a8d25b1f59fa 100644 --- a/app/code/Magento/Email/Test/Unit/Block/Adminhtml/Template/Render/SenderTest.php +++ b/app/code/Magento/Email/Test/Unit/Block/Adminhtml/Template/Render/SenderTest.php @@ -8,27 +8,35 @@ namespace Magento\Email\Test\Unit\Block\Adminhtml\Template\Render; +use Magento\Backend\Block\Context; use Magento\Email\Block\Adminhtml\Template\Grid\Renderer\Sender; use Magento\Framework\DataObject; +use Magento\Framework\Escaper; use PHPUnit\Framework\MockObject\MockObject; use PHPUnit\Framework\TestCase; class SenderTest extends TestCase { /** - * @var MockObject|Sender + * @var Sender */ - protected $block; + private $block; + + /** + * @var MockObject|Escaper + */ + private $escaperMock; /** * Setup environment */ protected function setUp(): void { - $this->block = $this->getMockBuilder(Sender::class) - ->disableOriginalConstructor() - ->setMethods(['escapeHtml']) - ->getMock(); + $this->escaperMock = $this->createMock(Escaper::class); + $contextMock = $this->createMock(Context::class); + $contextMock->method('getEscaper')->willReturn($this->escaperMock); + + $this->block = new Sender($contextMock); } /** @@ -37,8 +45,8 @@ protected function setUp(): void public function testRenderWithSenderNameAndEmail() { $templateSenderEmail = 'test'; - $this->block->expects($this->any())->method('escapeHtml')->with($templateSenderEmail) - ->willReturn('test'); + $this->escaperMock->expects($this->any())->method('escapeHtml')->with($templateSenderEmail) + ->willReturn($templateSenderEmail); $actualResult = $this->block->render( new DataObject( [ @@ -56,8 +64,8 @@ public function testRenderWithSenderNameAndEmail() public function testRenderWithNoSenderNameAndEmail() { $templateSenderEmail = ''; - $this->block->expects($this->any())->method('escapeHtml')->with($templateSenderEmail) - ->willReturn(''); + $this->escaperMock->expects($this->any())->method('escapeHtml')->with($templateSenderEmail) + ->willReturn($templateSenderEmail); $actualResult = $this->block->render( new DataObject( [ diff --git a/app/code/Magento/Email/view/adminhtml/templates/preview/iframeswitcher.phtml b/app/code/Magento/Email/view/adminhtml/templates/preview/iframeswitcher.phtml index 900c527dcff17..9f22756889d83 100644 --- a/app/code/Magento/Email/view/adminhtml/templates/preview/iframeswitcher.phtml +++ b/app/code/Magento/Email/view/adminhtml/templates/preview/iframeswitcher.phtml @@ -4,25 +4,28 @@ * See COPYING.txt for license details. */ -/** @var \Magento\Backend\Block\Page $block */ +/** + * @var \Magento\Backend\Block\Page $block + * @var \Magento\Framework\Escaper $escaper + */ /** @var \Magento\Framework\View\Helper\SecureHtmlRenderer $secureRenderer */ ?>