diff --git a/app/code/Magento/Shipping/view/adminhtml/templates/create/form.phtml b/app/code/Magento/Shipping/view/adminhtml/templates/create/form.phtml index 7de40943878cf..aaff6001040cc 100644 --- a/app/code/Magento/Shipping/view/adminhtml/templates/create/form.phtml +++ b/app/code/Magento/Shipping/view/adminhtml/templates/create/form.phtml @@ -6,44 +6,45 @@ /** * @var \Magento\Shipping\Block\Adminhtml\Create\Form $block + * @var \Magento\Framework\Escaper $escaper * @var \Magento\Framework\View\Helper\SecureHtmlRenderer $secureRenderer */ /** @var \Magento\Tax\Helper\Data $taxHelper */ $taxHelper = $block->getData('taxHelper'); ?> -
+ getBlockHtml('formkey') ?> getShipment()->getOrder() ?> getChildHtml('order_info') ?>
- escapeHtml(__('Payment & Shipping Method')) ?> + escapeHtml(__('Payment & Shipping Method')) ?>
- escapeHtml(__('Payment Information')) ?> + escapeHtml(__('Payment Information')) ?>
getPaymentHtml() ?>
- escapeHtml(__('The order was placed using %1.', $_order->getOrderCurrencyCode())) ?> + escapeHtml(__('The order was placed using %1.', $_order->getOrderCurrencyCode())) ?>
- escapeHtml(__('Shipping Information')) ?> + escapeHtml(__('Shipping Information')) ?>
- escapeHtml($_order->getShippingDescription()) ?> + escapeHtml($_order->getShippingDescription()) ?>
- escapeHtml(__('Total Shipping Charges')) ?>: + escapeHtml(__('Total Shipping Charges')) ?>: displayShippingPriceIncludingTax()): ?> displayShippingPriceInclTax($_order); ?> @@ -54,7 +55,7 @@ $taxHelper = $block->getData('taxHelper'); displayShippingBothPrices() && $_incl != $_excl): ?> - (escapeHtml(__('Incl. Tax')) ?> ) + (escapeHtml(__('Incl. Tax')) ?> )
diff --git a/app/code/Magento/Shipping/view/adminhtml/templates/create/items.phtml b/app/code/Magento/Shipping/view/adminhtml/templates/create/items.phtml index 9b55d2b969d3f..5ea54b08db2e1 100644 --- a/app/code/Magento/Shipping/view/adminhtml/templates/create/items.phtml +++ b/app/code/Magento/Shipping/view/adminhtml/templates/create/items.phtml @@ -4,24 +4,27 @@ * See COPYING.txt for license details. */ -/** @var \Magento\Framework\View\Helper\SecureHtmlRenderer $secureRenderer */ +/** + * @var \Magento\Framework\View\Helper\SecureHtmlRenderer $secureRenderer + * @var \Magento\Framework\Escaper $escaper + */ ?>
- escapeHtml(__('Items to Ship')) ?> + escapeHtml(__('Items to Ship')) ?>
- - + + canShipPartiallyItem()): ?> - + @@ -42,24 +45,24 @@
- escapeHtml(__('Shipment Total')) ?> + escapeHtml(__('Shipment Total')) ?>
- escapeHtml(__('Shipment Comments')) ?> + escapeHtml(__('Shipment Comments')) ?>
+ escapeHtml(__('Comment Text')) ?>
+ cols="5">escapeHtml($block->getShipment()->getCommentText()) ?>
@@ -67,7 +70,7 @@
- escapeHtml(__('Shipment Options')) ?> + escapeHtml(__('Shipment Options')) ?>
canCreateShippingLabel()): ?> @@ -79,7 +82,7 @@ type="checkbox"/> + escapeHtml(__('Create Shipping Label')) ?> renderEventListenerAsTag( 'onclick', 'toggleCreateLabelCheckbox();', @@ -96,7 +99,7 @@ type="checkbox"/> + escapeHtml(__('Append Comments')) ?>
canSendShipmentEmail()): ?> @@ -108,7 +111,7 @@ type="checkbox"/> + escapeHtml(__('Email Copy of Shipment')) ?>
getChildHtml('submit_before') ?> @@ -155,7 +158,7 @@ window.toggleCreateLabelCheckbox = function() { window.submitShipment = function(btn) { if (!validQtyItems()) { alert({ - content: '{$block->escapeJs(__('Invalid value(s) for Qty to Ship'))}' + content: '{$escaper->escapeJs(__('Invalid value(s) for Qty to Ship'))}' }); return; } diff --git a/app/code/Magento/Shipping/view/adminhtml/templates/order/packaging/grid.phtml b/app/code/Magento/Shipping/view/adminhtml/templates/order/packaging/grid.phtml index 7ddfc068fb115..6e290629ac838 100644 --- a/app/code/Magento/Shipping/view/adminhtml/templates/order/packaging/grid.phtml +++ b/app/code/Magento/Shipping/view/adminhtml/templates/order/packaging/grid.phtml @@ -6,6 +6,7 @@ //phpcs:disable Squiz.PHP.NonExecutableCode.Unreachable /** * @var \Magento\Shipping\Block\Adminhtml\Order\Packaging $block + * @var \Magento\Framework\Escaper $escaper * @var \Magento\Framework\View\Helper\SecureHtmlRenderer $secureRenderer */ ?> @@ -20,7 +21,7 @@ + title="escapeHtmlAttr(__('Select All')) ?>"> renderEventListenerAsTag( 'onchange', 'packaging.checkAllItems(this);', @@ -29,10 +30,10 @@ -
- + + displayCustomsValue()): ?> renderStyleAsTag( @@ -40,8 +41,8 @@ '#packaging-data-grid-' . $randomId . ' th.custom-value' ) ?> - - + + @@ -71,10 +72,10 @@ displayCustomsValue()) { @@ -88,7 +89,7 @@ displayCustomsValue()): ?> @@ -101,7 +102,7 @@ getOrderItem()->getQtyOrdered() * 1 ?>
escapeHtml(__('Product')) ?>escapeHtml(__('Qty')) ?>escapeHtml(__('Product')) ?>escapeHtml(__('Qty')) ?> - escapeHtml(__('Qty to Ship')) ?> + escapeHtml(__('Qty to Ship')) ?> escapeHtml(__('Ship')) ?>escapeHtml(__('Ship')) ?>
escapeHtml(__('Product Name')) ?>escapeHtml(__('Weight')) ?>escapeHtml(__('Product Name')) ?>escapeHtml(__('Weight')) ?> - escapeHtml(__('Customs Value')) ?> + escapeHtml(__('Customs Value')) ?> escapeHtml(__('Qty Ordered')) ?>escapeHtml(__('Qty')) ?>escapeHtml(__('Qty Ordered')) ?>escapeHtml(__('Qty')) ?>
- escapeHtml($item->getName()) ?> + escapeHtml($item->getName()) ?> - escapeHtml($item->getWeight()) ?> + escapeHtml($item->getWeight()) ?> - + - escapeHtml(__('Delete')) ?> + escapeHtml(__('Delete')) ?> renderStyleAsTag( 'display:none', diff --git a/app/code/Magento/Shipping/view/adminhtml/templates/order/packaging/packed.phtml b/app/code/Magento/Shipping/view/adminhtml/templates/order/packaging/packed.phtml index 90ecfa3862000..6b432c3e75d40 100644 --- a/app/code/Magento/Shipping/view/adminhtml/templates/order/packaging/packed.phtml +++ b/app/code/Magento/Shipping/view/adminhtml/templates/order/packaging/packed.phtml @@ -4,7 +4,10 @@ * See COPYING.txt for license details. */ -/** @var \Magento\Framework\View\Helper\SecureHtmlRenderer $secureRenderer */ +/** + * @var \Magento\Framework\View\Helper\SecureHtmlRenderer $secureRenderer + * @var \Magento\Framework\Escaper $escaper + */ /** @var \Magento\Shipping\Helper\Carrier $carrierHelper */ $carrierHelper = $block->getData('carrierHelper'); @@ -16,7 +19,7 @@ $carrierHelper = $block->getData('carrierHelper'); getParams()) ?>
- escapeHtml(__('Package') . ' ' . $packageId) ?> + escapeHtml(__('Package') . ' ' . $packageId) ?>
@@ -24,27 +27,27 @@ $carrierHelper = $block->getData('carrierHelper'); - + displayCustomsValue()): ?> - - + - - + getSize()): ?> - - + + @@ -54,10 +57,10 @@ $carrierHelper = $block->getData('carrierHelper');
escapeHtml(__('Type')) ?>escapeHtml(__('Type')) ?> - escapeHtml($block->getContainerTypeByCode($params->getContainer())) ?> + escapeHtml($block->getContainerTypeByCode($params->getContainer())) ?>
escapeHtml(__('Customs Value')) ?>escapeHtml($block->displayCustomsPrice($params->getCustomsValue())) ?> + escapeHtml(__('Customs Value')) ?>escapeHtml($block->displayCustomsPrice($params->getCustomsValue())) ?> escapeHtml(__('Total Weight')) ?>escapeHtml($params->getWeight() . ' ' . + escapeHtml(__('Total Weight')) ?>escapeHtml($params->getWeight() . ' ' . $carrierHelper->getMeasureWeightName($params->getWeightUnits())) ?>
escapeHtml(__('Size')) ?>escapeHtml(ucfirst(strtolower($params->getSize()))) ?>escapeHtml(__('Size')) ?>escapeHtml(ucfirst(strtolower($params->getSize()))) ?>
- + - + - + getDeliveryConfirmation() != null): ?> - + getContentType() != null): ?> - + getContentType() == 'OTHER'): ?> - + getGirth()): ?> - - + @@ -127,19 +130,19 @@ $carrierHelper = $block->getData('carrierHelper');
- escapeHtml(__('Items in the Package')) ?> + escapeHtml(__('Items in the Package')) ?>
escapeHtml(__('Length')) ?>escapeHtml(__('Length')) ?> getLength() != null): ?> - escapeHtml($params->getLength() . ' ' . + escapeHtml($params->getLength() . ' ' . $carrierHelper->getMeasureDimensionName($params->getDimensionUnits())) ?> -- @@ -65,10 +68,10 @@ $carrierHelper = $block->getData('carrierHelper');
escapeHtml(__('Width')) ?>escapeHtml(__('Width')) ?> getWidth() != null): ?> - escapeHtml($params->getWidth() . ' ' . + escapeHtml($params->getWidth() . ' ' . $carrierHelper->getMeasureDimensionName($params->getDimensionUnits())) ?> -- @@ -76,10 +79,10 @@ $carrierHelper = $block->getData('carrierHelper');
escapeHtml(__('Height')) ?>escapeHtml(__('Height')) ?> getHeight() != null): ?> - escapeHtml($params->getHeight() . ' ' . + escapeHtml($params->getHeight() . ' ' . $carrierHelper->getMeasureDimensionName($params->getDimensionUnits())) ?> -- @@ -94,29 +97,29 @@ $carrierHelper = $block->getData('carrierHelper');
escapeHtml(__('Signature Confirmation')) ?>escapeHtml(__('Signature Confirmation')) ?> - escapeHtml( + escapeHtml( $block->getDeliveryConfirmationTypeByCode($params->getDeliveryConfirmation()) ) ?>
escapeHtml(__('Contents')) ?>escapeHtml(__('Contents')) ?> escapeHtml($params->getContentTypeOther()) ?>escapeHtml($params->getContentTypeOther()) ?> - escapeHtml($block->getContentTypeByCode($params->getContentType())) + escapeHtml($block->getContentTypeByCode($params->getContentType())) ?>
escapeHtml(__('Girth')) ?>escapeHtml($params->getGirth() . ' ' . + escapeHtml(__('Girth')) ?>escapeHtml($params->getGirth() . ' ' . $carrierHelper->getMeasureDimensionName($params->getGirthDimensionUnits())) ?>
- - + + displayCustomsValue()): ?> - + - - + + @@ -147,18 +150,18 @@ $carrierHelper = $block->getData('carrierHelper'); displayCustomsValue()): ?>
escapeHtml(__('Product')) ?>escapeHtml(__('Weight')) ?>escapeHtml(__('Product')) ?>escapeHtml(__('Weight')) ?> escapeHtml(__('Customs Value')) ?>escapeHtml(__('Customs Value')) ?> escapeHtml(__('Qty Ordered')) ?>escapeHtml(__('Qty')) ?>escapeHtml(__('Qty Ordered')) ?>escapeHtml(__('Qty')) ?>
- escapeHtml($item->getName()) ?> + escapeHtml($item->getName()) ?> - escapeHtml($item->getWeight()) ?> + escapeHtml($item->getWeight()) ?> - escapeHtml($block->displayCustomsPrice($item->getCustomsValue())) ?> + escapeHtml($block->displayCustomsPrice($item->getCustomsValue())) ?> - escapeHtml($block->getQtyOrderedItem($item->getOrderItemId())) ?> + escapeHtml($block->getQtyOrderedItem($item->getOrderItemId())) ?> getQty()*1 ?> @@ -186,8 +189,8 @@ script; "#packed_window": { "Magento_Shipping/js/packages":{ "type":"slide", - "title":"escapeHtml(__('Packages')) ?>", - "url": "escapeUrl($block->getPrintButton()) ?>" + "title":"escapeHtml(__('Packages')) ?>", + "url": "escapeUrl($block->getPrintButton()) ?>" } } } diff --git a/app/code/Magento/Shipping/view/adminhtml/templates/order/packaging/popup.phtml b/app/code/Magento/Shipping/view/adminhtml/templates/order/packaging/popup.phtml index 6b188c21056e5..896e486d7e3bd 100644 --- a/app/code/Magento/Shipping/view/adminhtml/templates/order/packaging/popup.phtml +++ b/app/code/Magento/Shipping/view/adminhtml/templates/order/packaging/popup.phtml @@ -8,6 +8,7 @@ /** * @var $block \Magento\Shipping\Block\Adminhtml\Order\Packaging + * @var \Magento\Framework\Escaper $escaper * @var \Magento\Framework\View\Helper\SecureHtmlRenderer $secureRenderer */ ?> @@ -37,7 +38,7 @@ $girthEnabled = $block->isDisplayGirthValue() && $block->isGirthAllowed() ? 1 : packaging.sendCreateLabelRequest(); }); packaging.setLabelCreatedCallback(function(response){ - setLocation("{$block->escapeJs($block->getUrl( + setLocation("{$escaper->escapeJs($block->getUrl( 'sales/order/view', ['order_id' => $block->getShipment()->getOrderId()] ))}"); @@ -61,23 +62,23 @@ $girthEnabled = $block->isDisplayGirthValue() && $block->isGirthAllowed() ? 1 : }); jQuery('#packaging_window').modal({ type: 'slide', - title: '{$block->escapeJs(__('Create Packages'))}', + title: '{$escaper->escapeJs(__('Create Packages'))}', buttons: [{ - text: '{$block->escapeJs(__('Cancel'))}', + text: '{$escaper->escapeJs(__('Cancel'))}', 'class': 'action-secondary', click: function () { packaging.cancelPackaging(); this.closeModal(); } }, { - text: '{$block->escapeJs(__('Save'))}', + text: '{$escaper->escapeJs(__('Save'))}', 'attr': {'disabled':'disabled', 'data-action':'save-packages'}, 'class': 'action-primary _disabled', click: function () { packaging.confirmPackaging(); } }, { - text: '{$block->escapeJs(__('Add Package'))}', + text: '{$escaper->escapeJs(__('Add Package'))}', 'attr': {'data-action':'add-packages'}, 'class': 'action-secondary', click: function () { diff --git a/app/code/Magento/Shipping/view/adminhtml/templates/order/packaging/popup_content.phtml b/app/code/Magento/Shipping/view/adminhtml/templates/order/packaging/popup_content.phtml index 71299b33ff159..3ab90150b751c 100644 --- a/app/code/Magento/Shipping/view/adminhtml/templates/order/packaging/popup_content.phtml +++ b/app/code/Magento/Shipping/view/adminhtml/templates/order/packaging/popup_content.phtml @@ -6,6 +6,7 @@ /** * @var \Magento\Shipping\Block\Adminhtml\Order\Packaging $block + * @var \Magento\Framework\Escaper $escaper * @var \Magento\Framework\View\Helper\SecureHtmlRenderer $secureRenderer */ ?> @@ -14,18 +15,18 @@
- escapeHtml(__('Package')) ?> + escapeHtml(__('Package')) ?>
@@ -33,25 +34,25 @@ - + - - + + displayCustomsValue()): ?> renderStyleAsTag('display: none', 'th.col-custom') ?> - - - - + + + + getDeliveryConfirmationTypes()): ?> - + @@ -63,7 +64,7 @@ getContainers(); ?> @@ -82,8 +83,8 @@ @@ -120,7 +121,7 @@ name="package_customs_value" /> - escapeHtml($block->getCustomValueCurrencyCode()) ?> + escapeHtml($block->getCustomValueCurrencyCode()) ?> @@ -137,10 +138,10 @@ @@ -165,10 +166,10 @@ @@ -176,8 +177,8 @@ @@ -196,8 +197,8 @@
escapeHtml(__('Type')) ?>escapeHtml(__('Type')) ?> escapeHtml(__('Size')) ?>escapeHtml(__('Girth')) ?>escapeHtml(__('Size')) ?>escapeHtml(__('Girth')) ?>   - escapeHtml(__('Customs Value')) ?> + escapeHtml(__('Customs Value')) ?> escapeHtml(__('Total Weight')) ?>escapeHtml(__('Length')) ?>escapeHtml(__('Width')) ?>escapeHtml(__('Height')) ?>escapeHtml(__('Total Weight')) ?>escapeHtml(__('Length')) ?>escapeHtml(__('Width')) ?>escapeHtml(__('Height')) ?>   escapeHtml(__('Signature Confirmation')) ?>escapeHtml(__('Signature Confirmation')) ?>  
@@ -97,10 +98,10 @@ @@ -186,7 +187,7 @@
- - + + @@ -206,8 +207,8 @@ @@ -238,7 +239,7 @@ require(['jquery'], function($){ $("div#packages_content").on('change', "select[name='package_container']", function(){ packaging.changeContainerType(this); - packaging.checkSizeAndGirthParameter(this, {$block->escapeJs($girthEnabled)}) + packaging.checkSizeAndGirthParameter(this, {$escaper->escapeJs($girthEnabled)}) }); $("div#packages_content").on('change', "select[name='container_weight_units']", function(){packaging.changeMeasures(this)}); @@ -250,7 +251,7 @@ script; if ($girthEnabled == 1 && !empty($sizeSource)) { $scriptString .= <<
escapeHtml(__('Contents')) ?>escapeHtml(__('Explanation')) ?>escapeHtml(__('Contents')) ?>escapeHtml(__('Explanation')) ?>