From 1d40c9ac45d7fe3d1a490adad6603b4142e926a7 Mon Sep 17 00:00:00 2001 From: Wouter Samaey Date: Fri, 9 Jun 2017 10:06:06 +0200 Subject: [PATCH 1/2] Improved error logging: original exception was not passed as $cause --- app/code/Magento/Catalog/Model/ProductRepository.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/code/Magento/Catalog/Model/ProductRepository.php b/app/code/Magento/Catalog/Model/ProductRepository.php index ceacfea5ec020..c91ae62544615 100644 --- a/app/code/Magento/Catalog/Model/ProductRepository.php +++ b/app/code/Magento/Catalog/Model/ProductRepository.php @@ -634,7 +634,7 @@ public function save(\Magento\Catalog\Api\Data\ProductInterface $product, $saveO } catch (LocalizedException $e) { throw $e; } catch (\Exception $e) { - throw new \Magento\Framework\Exception\CouldNotSaveException(__('Unable to save product')); + throw new \Magento\Framework\Exception\CouldNotSaveException(__('Unable to save product'), $e); } unset($this->instances[$product->getSku()]); unset($this->instancesById[$product->getId()]); From fdb0c7f401033b0c1d839abb539a592035fdd588 Mon Sep 17 00:00:00 2001 From: Wouter Samaey Date: Fri, 9 Jun 2017 11:11:34 +0200 Subject: [PATCH 2/2] Added missing logging when saving a product fails --- app/code/Magento/Catalog/Controller/Adminhtml/Product/Save.php | 1 + 1 file changed, 1 insertion(+) diff --git a/app/code/Magento/Catalog/Controller/Adminhtml/Product/Save.php b/app/code/Magento/Catalog/Controller/Adminhtml/Product/Save.php index d307055f22bbf..5a83fa3e34fa8 100644 --- a/app/code/Magento/Catalog/Controller/Adminhtml/Product/Save.php +++ b/app/code/Magento/Catalog/Controller/Adminhtml/Product/Save.php @@ -144,6 +144,7 @@ public function execute() $this->messageManager->addSuccess(__('You duplicated the product.')); } } catch (\Magento\Framework\Exception\LocalizedException $e) { + $this->_objectManager->get(\Psr\Log\LoggerInterface::class)->critical($e); $this->messageManager->addError($e->getMessage()); $this->getDataPersistor()->set('catalog_product', $data); $redirectBack = $productId ? true : 'new';