Skip to content

DISCOVERY: Identify breaking changes and impact to PWA from 2.3.1 #948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
awilcoxa opened this issue Feb 25, 2019 · 3 comments
Closed

DISCOVERY: Identify breaking changes and impact to PWA from 2.3.1 #948

awilcoxa opened this issue Feb 25, 2019 · 3 comments
Assignees

Comments

@awilcoxa
Copy link

awilcoxa commented Feb 25, 2019

As a PWA core team, we need to understand all of the breaking items contained within the Magento 2.3.1 release which impact PWA in order to build out a plan for addressing and ensuring compatibility.

@awilcoxa
Copy link
Author

effort is currently in progress via email thread with @zetlen

@cherdman
Copy link
Contributor

From Zetlen:

magento/graphql-ce#132 is a breaking change to the GraphQL schema. This is the small_image change we’ve already found, escalated, and discussed. It changes the small_image in ProductInterface from a string to a complex type with path and url properties. Our Venia queries expect the simple string, so they cause a type error from the API, since complex types require a subselection. To fix this, we’ll need to update every place we use the small_image property: https://github.com/magento-research/pwa-studio/search?q=small_image&unscoped_q=small_image .

magento/graphql-ce#186 is a breaking change to the GraphQL schema. This changes the description and short_description fields in ProductInterface from strings to complex types with html properties. Our Venia queries expect the simple string, so they cause a type error from the API as in above. To fix this, we’ll need to update every place we use the description and short_description properties: https://github.com/magento-research/pwa-studio/search?l=GraphQL&q=description&type=Code

@cherdman cherdman added this to the Magento 2.3.1 Release milestone Feb 26, 2019
@awilcoxa
Copy link
Author

Closing as done as both issues reference above are accounted for in PR #653

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants