-
Notifications
You must be signed in to change notification settings - Fork 47
Linux: Handeling multithreading and better terminal settup #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2.7 was not supported or tested for a long time. Since mokypatch requires at least 3.6, this will be the first supporded version.
The `# -*- coding: utf-8 -*-` headers were useful for Python 2, and aren't needed for Python 3 where UTF-8 is the default.
LF and CR where swaped. They have the correct values now.
to allow for easier maintanace and proper separation every operation system gets a seperate set of files. They are exported by the module depending on `sys.platform`
The new setup uses a seperate folder for every operation system that tests are provided for. Test for a different operating system than the one currently running will be ignored.
The testscript now automatically knows of all special keys listed in the `key.py` submodule. It additionally outputs the hex representaion of all detected keys
github will now run precommit and pytest on all pushes and PRs automatically.
fixes #64, as described there, the raw wterminal can produce a lot of unneeded whitespace. Using the new configuration it seem to behave as expected.
`kbhit()` requires the terminal to be set up in a special way. So it is marked as an internal function to discurage use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally posted by @qianyun210603 in #79 (comment)
This version indeed solves issue 1 in #64 but unfortunately it doesn't fix issue 2 as per my test on my ovh server (running ubuntu). Below is my test script:
copy this into file and change the path in

sys.path.insert
to the "master" branch of local clone of your repo in r"/root/python-readchar-v4", I still see unwanted blanks (should come from the\r
generated bysetraw
and missing linebreaks between logs:In contrast, if using my version in pull request #64, I can get clean log outputs.

Would you please take some further look?
Thanks!