deprecation warnings when used with node v6.0.0

[mdouglass]

Using sqlite with node 6.0.0 (just released) gives numerous warnings likely because of the changes made to address nodejs/node#6216.

(node) v8::ObjectTemplate::Set() with non-primitive values is deprecated
(node) and will stop working in the next major release.

==== JS stack trace =========================================

Security context: 0x2ba0778c9fa9 <JS Object>#0#
    1: .node [module.js:568] [pc=0x34561141e264] (this=0x242bc69e2e59 <an Object with map 0x3ee4e1db53e9>#1#,module=0x1a9de2a804d1 <a Module with map 0x3ee4e1d181b9>#2#,filename=0x1a9de2a80499 <String[115]: /Users/mdouglass/kixeye/km/server/kmservices/node_modules/sqlite3/lib/binding/node-v48-darwin-x64/node_sqlite3.node>)
    2: load [module.js:~447] [pc=0x345611296e16] (this=0x1a9de2a804d1 <a Module with map 0x3ee4e1d181b9>#2#,filename=0x1a9de2a80499 <String[115]: /Users/mdouglass/kixeye/km/server/kmservices/node_modules/sqlite3/lib/binding/node-v48-darwin-x64/node_sqlite3.node>)
    3: tryModuleLoad(aka tryModuleLoad) [module.js:415] [pc=0x34561103899d] (this=0x2ba077804189 <undefined>,module=0x1a9de2a804d1 <a Module with map 0x3ee4e1d181b9>#2#,filename=0x1a9de2a80499 <String[115]: /Users/mdouglass/kixeye/km/server/kmservices/node_modules/sqlite3/lib/binding/node-v48-darwin-x64/node_sqlite3ease/method.js:39] [pc=0x345611c7dcdf] (this=0x274080472591 <JS Function Promise (SharedFunctionInfo 0x2cf6541298f1)>#15#,fn=0x1a9de276e6c1 <JS Function promises.push.Promise.try (SharedFunctionInfo 0x2cacd9561b59)>#16#)
   27: startServices(aka startServices) [/Users/mdouglass/kixeye/km/server/kmservices/lib/starter.js:28] [pc=0x345611c7d65f] (this=0x2ba077804189 <undefined>,services=0xb6382013d29 <JS Array[3]>#17#,config=0x232faff60ef1 <JS Object>#14#)
   28: /* anonymous */(aka /* anonymous */) [/Users/mdouglass/kixeye/km/server/kmservices/lib/starter.js:55] [pc=0x345611c7bea8] (this=0x2ba077804189 <undefined>)
   29: arguments adaptor frame: 1->0
   30: tryCatcher(aka tryCatcher) [/Users/mdouglass/kixeye/km/server/kmservices/node_modules/local-logger-service/node_modules/bluebird/js/main/util.js:26] [pc=0x3456113a830b] (this=0x2ba077804189 <undefined>)
   31: arguments adaptor frame: 1->0
   32: _settlePromiseFromHandler [/Users/mdouglass/kixeye/km/server/kmservices/node_modules/local-logger-service
==== C stack trace ===============================

 1: v8::Template::Set(v8::Local<v8::Name>, v8::Local<v8::Data>, v8::PropertyAttribute)
 2: node_sqlite3::Database::Init(v8::Local<v8::Object>)
 3: (anonymous namespace)::RegisterModule(v8::Local<v8::Object>)
 4: node::DLOpen(v8::FunctionCallbackInfo<v8::Value> const&)
 5: v8::internal::FunctionCallbackArguments::Call(void (*)(v8::FunctionCallbackInfo<v8::Value> const&))
 6: v8::internal::MaybeHandle<v8::internal::Object> v8::internal::(anonymous namespace)::HandleApiCallHelper<false>(v8::internal::Isolate*, v8::internal::(anonymous namespace)::BuiltinArguments<(v8::internal::BuiltinExtraArguments)1>)
 7: v8::internal::Builtin_HandleApiCall(int, v8::internal::Object**, v8::internal::Isolate*)
 8: 0x345610f0961b
 9: 0x34561141e264

[springmeyer]

Hmm, I think this is coming from https://github.com/mapbox/node-sqlite3/blob/155e45ef57e49398fa396c31bcad4a6607b49e3a/src/macros.h#L58-L63. I presume this needs to be fixed in https://github.com/nodejs/nan but I'm not sure.

[mdouglass]

Yeah, I think so too, just opened nodejs/nan#558

[springmeyer]

Watching fsevents/fsevents#128 too

[rs6g10]

+1

[BilalBoulifa]

+1 I was unable to install sqlite3 with node v6.

[frankhale]

Is there a way to suppress these warnings for now? I've tried --no-warnings and --no-deprecation but they still show up.

[frankhale]

Actually I think I figured out a way. I just rebuilt sqlite3 using nan 2.3.2 instead of the version it wants and the warnings go away. My app seems to be functioning fine.

[rs6g10]

as per frankhale's suggestion, using nan 2.3.2 does indeed fix the warnings.

[langpavel]

Works for me too:

npm install nan@^2.3.2
rm -rf node_modules/sqlite3/node_modules/nan/
npm rebuild sqlite3 --build-from-source

[zakdances]

My pull request should fix this. However AppVeyor is saying it failed tests on Windows with node version 0.10.40. Something to do with node-gyp? Don't know how this error is even related.