Skip to content

Commit a1fea83

Browse files
author
Marcos
committed
refactor: remove redudant signaling channels
1 parent b690e80 commit a1fea83

File tree

1 file changed

+8
-10
lines changed

1 file changed

+8
-10
lines changed

server/stdio.go

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -191,22 +191,20 @@ func (s *StdioServer) processInputStream(ctx context.Context, reader *bufio.Read
191191
func (s *StdioServer) readNextLine(ctx context.Context, reader *bufio.Reader) (string, error) {
192192
readChan := make(chan string, 1)
193193
errChan := make(chan error, 1)
194-
done := make(chan struct{})
195-
defer close(done)
196194

197195
go func() {
196+
select {
197+
case <-ctx.Done():
198+
return
199+
default:
200+
}
198201
line, err := reader.ReadString('\n')
199202
if err != nil {
200-
select {
201-
case errChan <- err:
202-
case <-done:
203-
}
203+
errChan <- err
204204
return
205205
}
206-
select {
207-
case readChan <- line:
208-
case <-done:
209-
}
206+
207+
readChan <- line
210208
}()
211209

212210
select {

0 commit comments

Comments
 (0)