Skip to content
This repository was archived by the owner on Mar 16, 2022. It is now read-only.

App bar icon ripples are clipped along edge of demo screen on Desktop (1) #208

Closed
rami-a opened this issue Nov 14, 2019 · 0 comments · Fixed by flutter/samples#289
Closed

App bar icon ripples are clipped along edge of demo screen on Desktop (1) #208

rami-a opened this issue Nov 14, 2019 · 0 comments · Fixed by flutter/samples#289
Assignees
@guidezpl
Labels
bug Something isn't working demo Building/fixing/updating a demo P4 Priority 4 - Won't have unless everything else is complete

Comments

@rami-a
Copy link
Contributor

rami-a commented Nov 14, 2019

Acceptance Criteria

  • No longer clipping

This is likely a result of how the margins are setup for desktop.
@rami-a rami-a added bug Something isn't working P4 Priority 4 - Won't have unless everything else is complete labels Nov 14, 2019
@rami-a rami-a added the demo Building/fixing/updating a demo label Dec 18, 2019
@rami-a rami-a changed the title App bar icon ripples are clipped along edge of demo screen on Desktop App bar icon ripples are clipped along edge of demo screen on Desktop (1) Jan 27, 2020
@guidezpl guidezpl self-assigned this Jan 28, 2020
@guidezpl guidezpl mentioned this issue Jan 28, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@guidezpl guidezpl

Labels
bug Something isn't working demo Building/fixing/updating a demo P4 Priority 4 - Won't have unless everything else is complete
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Gallery] Add padding to demo appBar flutter/samples
2 participants
@rami-a @guidezpl