Skip to content
This repository was archived by the owner on Mar 16, 2022. It is now read-only.

Add options to the tabs demo (2) #367

Closed
rami-a opened this issue Nov 26, 2019 · 2 comments · Fixed by flutter/samples#290
Closed

Add options to the tabs demo (2) #367

rami-a opened this issue Nov 26, 2019 · 2 comments · Fixed by flutter/samples#290
Assignees
@guidezpl
Labels
demo Building/fixing/updating a demo P4 Priority 4 - Won't have unless everything else is complete

Comments

@rami-a
Copy link
Contributor

rami-a commented Nov 26, 2019

Acceptance Criteria

  • Copy the options from the old gallery tabs demo
@rami-a rami-a added the P4 Priority 4 - Won't have unless everything else is complete label Nov 26, 2019
@rami-a rami-a added the demo Building/fixing/updating a demo label Dec 18, 2019
@rami-a rami-a changed the title Add options to the tabs demo Add options to the tabs demo (2) Jan 27, 2020
@guidezpl
Copy link
Member

guidezpl commented Jan 28, 2020 •
edited
Loading

Are the options here just scrolling/non-scrolling? The others seem superfluous (e.g. icons only)

@rami-a
Copy link
Contributor Author

rami-a commented Jan 28, 2020

I was originally thinking the options would be text only, icons only, text+icons but maybe you're right. Scrolling/non-scrolling might be a better demonstration. So let's do that

@guidezpl guidezpl self-assigned this Jan 28, 2020
@guidezpl guidezpl mentioned this issue Jan 28, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@guidezpl guidezpl

Labels
demo Building/fixing/updating a demo P4 Priority 4 - Won't have unless everything else is complete
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Gallery] Add options to tabs demo flutter/samples
2 participants
@rami-a @guidezpl