Skip to content
This repository was archived by the owner on Mar 16, 2022. It is now read-only.

Shrine - set hint text to products to indicate what happens when you tap them (1) #483

Closed
rami-a opened this issue Dec 9, 2019 · 2 comments · Fixed by flutter/samples#292
Closed

Shrine - set hint text to products to indicate what happens when you tap them (1) #483

rami-a opened this issue Dec 9, 2019 · 2 comments · Fixed by flutter/samples#292
Assignees
@perclasson
Labels
a11y P2 Priority 2 - Should have

Comments

@rami-a
Copy link
Contributor

rami-a commented Dec 9, 2019

Acceptance Criteria

  • Semantic hint that indicates that tapping products will add them to cart
@rami-a rami-a added P2 Priority 2 - Should have a11y labels Dec 9, 2019
@rami-a rami-a changed the title Shrine - set hint text to products to indicate what happens when you tap them Shrine - set hint text to products to indicate what happens when you tap them (1) Jan 28, 2020
@perclasson perclasson self-assigned this Jan 29, 2020
@perclasson
Copy link
Contributor

perclasson commented Jan 29, 2020 •
edited
Loading

This is already added for TalkBack for Android. For VoiceOver it does not read the onTapHint. Not sure if this is expected or not. Will investigate further...

@perclasson
Copy link
Contributor

Found that this is intended behaviour:
https://api.flutter.dev/flutter/semantics/SemanticsHintOverrides-class.html

Will have to add a separate hint for VoiceOver.

This was referenced Jan 29, 2020
Closed
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@perclasson perclasson

Labels
a11y P2 Priority 2 - Should have
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Gallery] Exclude semantics for logo and change to hint for products on Shrine perclasson/samples
2 participants
@perclasson @rami-a