Improves process management during restart workflows with matlab-proxy-manager.

Author: krisctl

matlab_proxy_manager/lib/api.py

@@ -253,6 +253,11 @@ async def _initialize_process_based_on_os_type(cmd, env):
             return await asyncio.create_subprocess_exec(
                 *cmd,
                 env=env,
+                # kernel sporadically ends up cleaning the child matlab-proxy process during the
+                # restart workflow. This is a workaround to handle that race condition which leads
+                # to starting matlab-proxy in a new process group and is not counted for deletion.
+                # https://github.com/ipython/ipykernel/blob/main/ipykernel/kernelbase.py#L1283
+                start_new_session=True,
             )
         except Exception as e:
             log.error("Failed to create posix subprocess: %s", e)

matlab_proxy_manager/utils/helpers.py

@@ -153,15 +153,15 @@ def _are_orphaned_servers_deleted(predicate: Optional[str] = "") -> bool:
     servers: dict = storage.get_all()
 
     def _matches_predicate(filename: str) -> bool:
-        return filename.split("_")[0] == predicate
+        return filename.split("_")[0] == str(predicate)
 
     # Checks only a subset of servers (that matches the parent_pid of the caller)
     # to reduce the MATLAB proxy startup time
     if predicate:
         servers = {
             filename: server
             for filename, server in servers.items()
-            if _matches_predicate(filename)
+            if _matches_predicate(Path(filename).stem)
         }
         if not servers:
             log.debug("Parent pid not matched, nothing to cleanup")