Skip to content

Adds support for multiple registries. Fixes #3 #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 26, 2017
Merged

Adds support for multiple registries. Fixes #3 #4

merged 2 commits into from
Jan 26, 2017

Conversation

bedeoverend
Copy link
Collaborator

Uses the document node over document.documentElement so as to support arbitrary Node's being passed in for observation. This is intended for observing Shadow Trees.

Also add CustomAttributeRegistry as a global on window to allow creating extra registries for other documents / trees e.g. Shadow Trees.

Fixes #3

@matthewp matthewp merged commit dddfc77 into matthewp:master Jan 26, 2017
@matthewp
Copy link
Owner

I released this as 1.0.0 (as I don't see the API changing too much in the future).

@matthewp
Copy link
Owner

I've also added you as a collaborator @bedeoverend: https://github.com/matthewp/custom-attributes/invitations

Thanks!

@bedeoverend
Copy link
Collaborator Author

Fantastic - thanks @matthewp!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants