Merge pull request #309 from mattpolzin/fix-double-validation

fix double-validation error reporting

Author: mattpolzin

Sources/OpenAPIKit/Validator/Validator.swift

@@ -26,11 +26,7 @@ extension OpenAPI.Document {
         let validator = _Validator(document: self, validations: validator.validations)
         var container = validator.singleValueContainer()
 
-        // we kick things off by applying validations to the root (OpenAPI.Document)
-        // and then encoding with the single value container.
-        // After this, validations are only applied by keyed/unkeyed containers and
-        // by the leaf node methods of the single value container.
-        validator.applyValidations(to: self)
+        // Validation is done by "encoding"
         try container.encode(self)
 
         if !validator.errors.isEmpty {

Tests/OpenAPIKitTests/Validator/BuiltinValidationTests.swift

@@ -24,6 +24,7 @@ final class BuiltinValidationTests: XCTestCase {
             let error = error as? ValidationErrorCollection
             XCTAssertEqual(error?.values.first?.reason, "Failed to satisfy: Document contains at least one path")
             XCTAssertEqual(error?.values.first?.codingPath.map { $0.stringValue }, ["paths"])
+            XCTAssertEqual(error?.values.count, 1)
         }
     }
 
@@ -57,6 +58,7 @@ final class BuiltinValidationTests: XCTestCase {
             let error = error as? ValidationErrorCollection
             XCTAssertEqual(error?.values.first?.reason, "Failed to satisfy: Paths contain at least one operation")
             XCTAssertEqual(error?.values.first?.codingPath.map { $0.stringValue }, ["paths", "/hello/world"])
+            XCTAssertEqual(error?.values.count, 1)
         }
     }