Skip to content

Commit 95d5d11

Browse files
gabrielbullfacebook-github-bot
authored andcommitted
Fixed issue with install third party script in directory with spaces
Summary: Fixes an issue with installing third party on iOS when the project's path contains a space, no matter where the space is in the path. __Error__ ``` /Users/AwesomeUser/Library/Developer/Xcode/DerivedData/AwesomeProject-xxx/Build/Intermediates.noindex/React.build/Debug-iphoneos/double-conversion.build/Script-190EE32F1E6A43DE00A8543A.sh: line 3: /Users/AwesomeUser/path contain space/scripts/ios-install-third-party.sh: No such file or directory /Users/AwesomeUser/Library/Developer/Xcode/DerivedData/AwesomeProject-xxx/Build/Intermediates.noindex/React.build/Debug-iphoneos/double-conversion.build/Script-190EE32F1E6A43DE00A8543A.sh: line 3: exec: /Users/AwesomeUser/path contain space/scripts/ios-install-third-party.sh: cannot execute: No such file or directory ``` Closes facebook#15377 Differential Revision: D5572671 Pulled By: shergin fbshipit-source-id: 102727fc1b820e399e170c9c0cb73fd5d1e018d5
1 parent ec74a96 commit 95d5d11

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

React/React.xcodeproj/project.pbxproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3491,7 +3491,7 @@
34913491
);
34923492
runOnlyForDeploymentPostprocessing = 0;
34933493
shellPath = /bin/sh;
3494-
shellScript = "cd $SRCROOT/..\nexec ./scripts/ios-install-third-party.sh";
3494+
shellScript = "cd \"$SRCROOT/..\"\nexec ./scripts/ios-install-third-party.sh";
34953495
};
34963496
2D6948201DA3042200B3FA97 /* Include RCTJSCProfiler */ = {
34973497
isa = PBXShellScriptBuildPhase;

scripts/ios-install-third-party.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ mkdir -p third-party
3333

3434
SCRIPTDIR=$(dirname "$0")
3535

36-
fetch_and_unpack glog-0.3.4.tar.gz https://github.com/google/glog/archive/v0.3.4.tar.gz "$SCRIPTDIR/ios-configure-glog.sh"
36+
fetch_and_unpack glog-0.3.4.tar.gz https://github.com/google/glog/archive/v0.3.4.tar.gz "\"$SCRIPTDIR/ios-configure-glog.sh\""
3737
fetch_and_unpack double-conversion-1.1.5.tar.gz https://github.com/google/double-conversion/archive/v1.1.5.tar.gz
3838
fetch_and_unpack boost_1_63_0.tar.gz https://github.com/react-native-community/boost-for-react-native/releases/download/v1.63.0-0/boost_1_63_0.tar.gz
3939
fetch_and_unpack folly-2016.09.26.00.tar.gz https://github.com/facebook/folly/archive/v2016.09.26.00.tar.gz

0 commit comments

Comments
 (0)