Skip to content

Commit 79aa0fe

Browse files
author
Leandro Pinto
committed
Some adjustems to incorporate feedback from the initial PR
1 parent c914197 commit 79aa0fe

File tree

3 files changed

+38
-41
lines changed

3 files changed

+38
-41
lines changed

api/src/main/java/com/messagebird/MessageBirdClient.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -496,17 +496,13 @@ Verify getVerifyObject(String id) throws NotFoundException, GeneralException, Un
496496
}
497497

498498
/**
499-
*
500-
* This method can be used to retrieve a Verify Email Message
501-
*
502499
* @param id id is for the email message part of a verify object
503500
* @return Verify object
504501
* @throws NotFoundException if id is not found
505502
* @throws UnauthorizedException if client is unauthorized
506503
* @throws GeneralException general exception
507504
*/
508505
public VerifyMessage getVerifyEmailMessage(String messageId) throws UnauthorizedException, GeneralException, NotFoundException {
509-
// TODO Auto-generated method stub
510506
if (messageId == null || messageId.isEmpty()) {
511507
throw new IllegalArgumentException("ID cannot be empty for verify email message");
512508
}

api/src/main/java/com/messagebird/objects/VerifyRequest.java

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -55,10 +55,9 @@ public void setType(VerifyType type) {
5555
this.type = type;
5656
}
5757

58-
public void setType(String type) {
58+
public void setType(String type) {
5959
this.type = VerifyType.valueOf(type.toUpperCase());
60-
}
61-
60+
}
6261

6362
/**
6463
* The datacoding used by the template.
@@ -118,11 +117,11 @@ public void setLanguage(Language language) {
118117
this.language = language;
119118
}
120119

121-
public void setSubject(String subject) {
122-
this.subject = subject;
123-
}
120+
public void setSubject(String subject) {
121+
this.subject = subject;
122+
}
124123

125-
public String getSubject() {
126-
return subject;
127-
}
124+
public String getSubject() {
125+
return subject;
126+
}
128127
}

examples/src/main/java/ExampleVerifyEmail.java

Lines changed: 30 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -9,41 +9,43 @@
99
import com.messagebird.objects.VerifyRequest;
1010

1111
/**
12-
* Created by faizan on 10/12/15.
12+
* Created by leandro.pinto on 23/06/21.
1313
*/
1414
public class ExampleVerifyEmail {
1515

1616
public static void main(String[] args) throws UnauthorizedException, GeneralException, NotFoundException {
17-
18-
final String ACCESS_KEY = args[0];
19-
final String METHOD = args[1];
20-
17+
18+
final String ACCESS_KEY = args[0];
19+
final String METHOD = args[1];
20+
2121
final MessageBirdService wsr = new MessageBirdServiceImpl(ACCESS_KEY);
22-
// Add the service to the client
2322
final MessageBirdClient messageBirdClient = new MessageBirdClient(wsr);
23+
Verify verify = null;
24+
25+
switch (METHOD) {
26+
case "send":
27+
VerifyRequest request = new VerifyRequest("<ADD RECIPIENT>");
28+
request.setType("email");
29+
request.setOriginator("<ADD ORIGINATOR>");
30+
request.setSubject("<ADD SUBJECT>");
31+
request.setTimeout(300);
32+
33+
verify = messageBirdClient.sendVerifyToken(request);
34+
System.out.println(verify.toString());
35+
36+
break;
37+
case "verify":
38+
final String VERIFY_ID = args[2];
39+
final String TOKEN = args[3];
2440

25-
if("send".equals(METHOD)) {
26-
VerifyRequest request = new VerifyRequest("<ADD RECIPIENT>");
27-
request.setType("email");
28-
request.setOriginator("<ADD ORIGINATOR>");
29-
request.setSubject("<ADD SUBJECT>");
30-
request.setTimeout(300);
31-
32-
33-
Verify verify = messageBirdClient.sendVerifyToken(request);
34-
System.out.println(verify.toString());
35-
}
36-
else if("verify".equals(METHOD)) {
37-
final String VERIFY_ID = args[2];
38-
final String TOKEN = args[3];
39-
40-
Verify verify = messageBirdClient.verifyToken(VERIFY_ID, TOKEN);
41+
verify = messageBirdClient.verifyToken(VERIFY_ID, TOKEN);
4142
System.out.println(verify.toString());
42-
}
43-
else if("view".equals(METHOD)) {
44-
final String MESSAGE_ID = args[2];
45-
VerifyMessage verify = messageBirdClient.getVerifyEmailMessage(MESSAGE_ID);
46-
System.out.println(verify.toString());
47-
}
43+
break;
44+
case "view":
45+
final String MESSAGE_ID = args[2];
46+
VerifyMessage verifyMessage = messageBirdClient.getVerifyEmailMessage(MESSAGE_ID);
47+
System.out.println(verifyMessage.toString());
48+
break;
49+
}
4850
}
4951
}

0 commit comments

Comments
 (0)