Skip to content

There are wrong members in AccessKey for ChildAccountCreateResponse because of wrong documentation #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ssk910 opened this issue Oct 29, 2021 · 3 comments

Comments

@ssk910
Copy link
Contributor

ssk910 commented Oct 29, 2021

Hello MessageBird team.

I have an issue with Partner Accounts API.
First of all, the Rest API documentation is wrong for Partner Accounts - Create a Child Account.

According to document above, accessKeys object from response has only id, key, mode fields.
But, when I actually send a request to https://partner-accounts.messagebird.com/child-accounts via Postman,
accessKeys object from its response has 8 fields including id, access_key, mode, description.

So, since a lack of an official documents, An AccessKey class which exists for response need to be fixed.

Thank you.

@denizkilic
Copy link
Contributor

Hi @ssk910,
Thanks for creating the issue. A PR is created, this issue will be solved in the next release. I will inform you when the new release is ready.

@denizkilic denizkilic mentioned this issue Nov 9, 2021
@denizkilic
Copy link
Contributor

Hi @ssk910,

This issue is fixed by the new release. Please let us know if you have more issues.

@ssk910
Copy link
Contributor Author

ssk910 commented Nov 9, 2021

I'll check later. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants