Skip to content

Commit 059c9aa

Browse files
committed
Use class references instead of strings on test assertions
1 parent 86bb655 commit 059c9aa

File tree

13 files changed

+63
-63
lines changed

13 files changed

+63
-63
lines changed

tests/integration/HttpClientTest.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public function testHttpClientValidTimeoutBoundary()
3636
public function testHttpClientInvalidConnectionTimeout()
3737
{
3838
$this->expectException('InvalidArgumentException');
39-
$this->expectExceptionMessageRegExp('#^Connection timeout must be an int >= 0, got "stdClass".$#');
39+
$this->expectExceptionMessageRegExp('/^Connection timeout must be an int >= 0, got "stdClass".$/');
4040
new HttpClient(Client::ENDPOINT, 10, new \stdClass());
4141
}
4242

@@ -56,7 +56,7 @@ public function testHttpClientValidConnectionTimeoutBoundary()
5656
public function testHttpClientWithoutAuthenticationException()
5757
{
5858
$this->expectException('MessageBird\Exceptions\AuthenticateException');
59-
$this->expectExceptionMessageRegExp('#Can not perform API Request without Authentication#');
59+
$this->expectExceptionMessageRegExp('/Can not perform API Request without Authentication/');
6060
$client = new HttpClient(Client::ENDPOINT);
6161
$client->performHttpRequest('foo', 'bar');
6262
}

tests/integration/balance/BalanceTest.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ protected function setUp(): void
99

1010
public function testReadBalance()
1111
{
12-
$this->expectException('MessageBird\Exceptions\ServerException');
12+
$this->expectException(\MessageBird\Exceptions\ServerException::class);
1313
$this->expectException(\MessageBird\Exceptions\ServerException::class);
1414
$this->mockClient->expects($this->once())->method('performHttpRequest')->with("GET", 'balance', null, null);
1515
$this->client->balance->read();

tests/integration/chat/ChatTest.php

+10-10
Original file line numberDiff line numberDiff line change
@@ -21,14 +21,14 @@ public function testCreateChatMessage()
2121

2222
public function testListChatMessage()
2323
{
24-
$this->expectException('MessageBird\Exceptions\ServerException');
24+
$this->expectException(\MessageBird\Exceptions\ServerException::class);
2525
$this->mockClient->expects($this->once())->method('performHttpRequest')->with("GET", 'messages', array ('offset' => 100, 'limit' => 30), null);
2626
$ChatMessageList = $this->client->chatMessages->getList(array ('offset' => 100, 'limit' => 30));
2727
}
2828

2929
public function testReadChatMessage()
3030
{
31-
$this->expectException('MessageBird\Exceptions\ServerException');
31+
$this->expectException(\MessageBird\Exceptions\ServerException::class);
3232
$this->mockClient->expects($this->once())->method('performHttpRequest')->with("GET", 'messages/id', null, null);
3333
$ChatMessageList = $this->client->chatMessages->read("id");
3434
}
@@ -53,21 +53,21 @@ public function testCreateChatChannel()
5353

5454
public function testListChatChannels()
5555
{
56-
$this->expectException('MessageBird\Exceptions\ServerException');
56+
$this->expectException(\MessageBird\Exceptions\ServerException::class);
5757
$this->mockClient->expects($this->once())->method('performHttpRequest')->with("GET", 'channels', array ('offset' => 100, 'limit' => 30), null);
5858
$ChannelList = $this->client->chatChannels->getList(array ('offset' => 100, 'limit' => 30));
5959
}
6060

6161
public function testReadChatChannel()
6262
{
63-
$this->expectException('MessageBird\Exceptions\ServerException');
63+
$this->expectException(\MessageBird\Exceptions\ServerException::class);
6464
$this->mockClient->expects($this->once())->method('performHttpRequest')->with("GET", 'channels/id', null, null);
6565
$Channel = $this->client->chatChannels->read("id");
6666
}
6767

6868
public function testDeleteChannel()
6969
{
70-
$this->expectException('MessageBird\Exceptions\ServerException');
70+
$this->expectException(\MessageBird\Exceptions\ServerException::class);
7171
$this->mockClient->expects($this->once())->method('performHttpRequest')->with("DELETE", 'channels/id', null, null);
7272
$Channel = $this->client->chatChannels->delete("id");
7373
}
@@ -85,35 +85,35 @@ public function testUpdateChatChannel()
8585

8686
public function testListChatPlatforms()
8787
{
88-
$this->expectException('MessageBird\Exceptions\ServerException');
88+
$this->expectException(\MessageBird\Exceptions\ServerException::class);
8989
$this->mockClient->expects($this->once())->method('performHttpRequest')->with("GET", 'platforms', array ('offset' => 100, 'limit' => 30), null);
9090
$ChannelList = $this->client->chatPlatforms->getList(array ('offset' => 100, 'limit' => 30));
9191
}
9292

9393
public function testReadChatPlatform()
9494
{
95-
$this->expectException('MessageBird\Exceptions\ServerException');
95+
$this->expectException(\MessageBird\Exceptions\ServerException::class);
9696
$this->mockClient->expects($this->once())->method('performHttpRequest')->with("GET", 'platforms/id', null, null);
9797
$Channel = $this->client->chatPlatforms->read("id");
9898
}
9999

100100
public function testListChatContacts()
101101
{
102-
$this->expectException('MessageBird\Exceptions\ServerException');
102+
$this->expectException(\MessageBird\Exceptions\ServerException::class);
103103
$this->mockClient->expects($this->once())->method('performHttpRequest')->with("GET", 'contacts', array ('offset' => 100, 'limit' => 30), null);
104104
$ContactList = $this->client->chatContacts->getList(array ('offset' => 100, 'limit' => 30));
105105
}
106106

107107
public function testReadChatContact()
108108
{
109-
$this->expectException('MessageBird\Exceptions\ServerException');
109+
$this->expectException(\MessageBird\Exceptions\ServerException::class);
110110
$this->mockClient->expects($this->once())->method('performHttpRequest')->with("GET", 'contacts/id', null, null);
111111
$Contact = $this->client->chatContacts->read("id");
112112
}
113113

114114
public function testDeleteContact()
115115
{
116-
$this->expectException('MessageBird\Exceptions\ServerException');
116+
$this->expectException(\MessageBird\Exceptions\ServerException::class);
117117
$this->mockClient->expects($this->once())->method('performHttpRequest')->with("DELETE", 'contacts/id', null, null);
118118
$contact = $this->client->chatContacts->delete("id");
119119
}

tests/integration/contacts/ContactTest.php

+3-3
Original file line numberDiff line numberDiff line change
@@ -47,21 +47,21 @@ public function testCreateContact()
4747

4848
public function testListContacts()
4949
{
50-
$this->expectException('MessageBird\Exceptions\ServerException');
50+
$this->expectException(\MessageBird\Exceptions\ServerException::class);
5151
$this->mockClient->expects($this->once())->method('performHttpRequest')->with("GET", 'contacts', array ('offset' => 100, 'limit' => 30), null);
5252
$this->client->contacts->getList(array ('offset' => 100, 'limit' => 30));
5353
}
5454

5555
public function testViewContact()
5656
{
57-
$this->expectException('MessageBird\Exceptions\ServerException');
57+
$this->expectException(\MessageBird\Exceptions\ServerException::class);
5858
$this->mockClient->expects($this->once())->method('performHttpRequest')->with("GET", 'contacts/contact_id', null, null);
5959
$this->client->contacts->read("contact_id");
6060
}
6161

6262
public function testDeleteContact()
6363
{
64-
$this->expectException('MessageBird\Exceptions\ServerException');
64+
$this->expectException(\MessageBird\Exceptions\ServerException::class);
6565
$this->mockClient->expects($this->once())->method('performHttpRequest')->with("DELETE", 'contacts/contact_id', null, null);
6666
$this->client->contacts->delete("contact_id");
6767
}

tests/integration/groups/GroupTest.php

+3-3
Original file line numberDiff line numberDiff line change
@@ -29,21 +29,21 @@ public function testCreateGroup()
2929

3030
public function testListGroups()
3131
{
32-
$this->expectException('MessageBird\Exceptions\ServerException');
32+
$this->expectException(\MessageBird\Exceptions\ServerException::class);
3333
$this->mockClient->expects($this->once())->method('performHttpRequest')->with("GET", 'groups', array ('offset' => 100, 'limit' => 30), null);
3434
$this->client->groups->getList(array ('offset' => 100, 'limit' => 30));
3535
}
3636

3737
public function testViewGroup()
3838
{
39-
$this->expectException('MessageBird\Exceptions\ServerException');
39+
$this->expectException(\MessageBird\Exceptions\ServerException::class);
4040
$this->mockClient->expects($this->once())->method('performHttpRequest')->with("GET", 'groups/group_id', null, null);
4141
$this->client->groups->read("group_id");
4242
}
4343

4444
public function testDeleteGroup()
4545
{
46-
$this->expectException('MessageBird\Exceptions\ServerException');
46+
$this->expectException(\MessageBird\Exceptions\ServerException::class);
4747
$this->mockClient->expects($this->once())->method('performHttpRequest')->with("DELETE", 'groups/group_id', null, null);
4848
$this->client->groups->delete("group_id");
4949
}

tests/integration/hlr/HlrTest.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ protected function setUp(): void
99

1010
public function testCreateHlr()
1111
{
12-
$this->expectException('MessageBird\Exceptions\ServerException');
12+
$this->expectException(\MessageBird\Exceptions\ServerException::class);
1313
$Hlr = new \MessageBird\Objects\Hlr();
1414
$Hlr->msisdn = 'MessageBird';
1515
$Hlr->reference = "yoloswag3000";
@@ -21,7 +21,7 @@ public function testCreateHlr()
2121

2222
public function testReadHlr()
2323
{
24-
$this->expectException('MessageBird\Exceptions\ServerException');
24+
$this->expectException(\MessageBird\Exceptions\ServerException::class);
2525
$this->mockClient->expects($this->once())->method('performHttpRequest')->with("GET", 'hlr/message_id', null, null);
2626
$this->client->hlr->read("message_id");
2727
}

tests/integration/lookup/LookupTest.php

+9-9
Original file line numberDiff line numberDiff line change
@@ -9,28 +9,28 @@ protected function setUp(): void
99

1010
public function testReadLookup()
1111
{
12-
$this->expectException('MessageBird\Exceptions\ServerException');
12+
$this->expectException(\MessageBird\Exceptions\ServerException::class);
1313
$this->mockClient->expects($this->once())->method('performHttpRequest')->with("GET", 'lookup/31612345678', null, null);
1414
$this->client->lookup->read(31612345678);
1515
}
1616

1717
public function testReadLookupWithEmptyNumber()
1818
{
19-
$this->expectException('InvalidArgumentException');
19+
$this->expectException(\InvalidArgumentException::class);
2020
$this->client->lookup->read(null);
2121
}
2222

2323
public function testReadLookupWithCountryCode()
2424
{
25-
$this->expectException('MessageBird\Exceptions\ServerException');
25+
$this->expectException(\MessageBird\Exceptions\ServerException::class);
2626
$params = array("countryCode" => "NL");
2727
$this->mockClient->expects($this->once())->method('performHttpRequest')->with("GET", 'lookup/612345678', $params, null);
2828
$this->client->lookup->read(612345678, $params["countryCode"]);
2929
}
3030

3131
public function testCreateLookupHlr()
3232
{
33-
$this->expectException('MessageBird\Exceptions\ServerException');
33+
$this->expectException(\MessageBird\Exceptions\ServerException::class);
3434
$Hlr = new \MessageBird\Objects\Hlr();
3535
$Hlr->msisdn = 31612345678;
3636
$Hlr->reference = 'Yoloswag3007';
@@ -42,15 +42,15 @@ public function testCreateLookupHlr()
4242

4343
public function testCreateLookupHlrWithEmptyNumber()
4444
{
45-
$this->expectException('InvalidArgumentException');
45+
$this->expectException(\InvalidArgumentException::class);
4646
$Hlr = new \MessageBird\Objects\Hlr();
4747
$Hlr->msisdn = null;
4848
$this->client->lookupHlr->create($Hlr);
4949
}
5050

5151
public function testCreateLookupHlrWithCountryCode()
5252
{
53-
$this->expectException('MessageBird\Exceptions\ServerException');
53+
$this->expectException(\MessageBird\Exceptions\ServerException::class);
5454
$Hlr = new \MessageBird\Objects\Hlr();
5555
$Hlr->msisdn = 612345678;
5656
$Hlr->reference = "CoolReference";
@@ -64,20 +64,20 @@ public function testCreateLookupHlrWithCountryCode()
6464

6565
public function testReadLookupHlr()
6666
{
67-
$this->expectException('MessageBird\Exceptions\ServerException');
67+
$this->expectException(\MessageBird\Exceptions\ServerException::class);
6868
$this->mockClient->expects($this->once())->method('performHttpRequest')->with("GET", 'lookup/31612345678/hlr', null, null);
6969
$this->client->lookupHlr->read(31612345678);
7070
}
7171

7272
public function testReadLookupHlrWithEmptyNumber()
7373
{
74-
$this->expectException('InvalidArgumentException');
74+
$this->expectException(\InvalidArgumentException::class);
7575
$this->client->lookupHlr->read(null);
7676
}
7777

7878
public function testReadLookupHlrWithCountryCode()
7979
{
80-
$this->expectException('MessageBird\Exceptions\ServerException');
80+
$this->expectException(\MessageBird\Exceptions\ServerException::class);
8181
$params = array("countryCode" => "NL");
8282
$this->mockClient->expects($this->once())->method('performHttpRequest')->with("GET", 'lookup/612345678/hlr', $params, null);
8383
$this->client->lookupHlr->read(612345678, $params["countryCode"]);

tests/integration/messages/MessagesTest.php

+6-6
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ public function testCreateMessage()
5252

5353
public function testPremiumSmsMessage()
5454
{
55-
$this->expectException('MessageBird\Exceptions\ServerException');
55+
$this->expectException(\MessageBird\Exceptions\ServerException::class);
5656
$Message = new \MessageBird\Objects\Message();
5757
$Message->originator = 'MessageBird';
5858
$Message->recipients = array(31612345678);
@@ -64,7 +64,7 @@ public function testPremiumSmsMessage()
6464

6565
public function testBinarySmsMessage()
6666
{
67-
$this->expectException('MessageBird\Exceptions\ServerException');
67+
$this->expectException(\MessageBird\Exceptions\ServerException::class);
6868
$Message = new \MessageBird\Objects\Message();
6969
$Message->originator = 'MessageBird';
7070
$Message->recipients = array(31612345678);
@@ -77,7 +77,7 @@ public function testBinarySmsMessage()
7777

7878
public function testFlashSmsMessage()
7979
{
80-
$this->expectException('MessageBird\Exceptions\ServerException');
80+
$this->expectException(\MessageBird\Exceptions\ServerException::class);
8181
$Message = new \MessageBird\Objects\Message();
8282
$Message->originator = 'MessageBird';
8383
$Message->recipients = array(31612345678);
@@ -91,21 +91,21 @@ public function testFlashSmsMessage()
9191

9292
public function testListMessage()
9393
{
94-
$this->expectException('MessageBird\Exceptions\ServerException');
94+
$this->expectException(\MessageBird\Exceptions\ServerException::class);
9595
$this->mockClient->expects($this->once())->method('performHttpRequest')->with("GET", 'messages', array ('offset' => 100, 'limit' => 30), null);
9696
$this->client->messages->getList(array ('offset' => 100, 'limit' => 30));
9797
}
9898

9999
public function testReadMessage()
100100
{
101-
$this->expectException('MessageBird\Exceptions\ServerException');
101+
$this->expectException(\MessageBird\Exceptions\ServerException::class);
102102
$this->mockClient->expects($this->once())->method('performHttpRequest')->with("GET", 'messages/message_id', null, null);
103103
$this->client->messages->read("message_id");
104104
}
105105

106106
public function testDeleteMessage()
107107
{
108-
$this->expectException('MessageBird\Exceptions\ServerException');
108+
$this->expectException(\MessageBird\Exceptions\ServerException::class);
109109
$this->mockClient->expects($this->once())->method('performHttpRequest')->with("DELETE", 'messages/message_id', null, null);
110110
$this->client->messages->delete("message_id");
111111
}

tests/integration/mms/MmsTest.php

+3-3
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ class MmsTest extends BaseTest
33
{
44
public function testCreateMmsFail()
55
{
6-
$this->expectException('MessageBird\Exceptions\RequestException');
6+
$this->expectException(\MessageBird\Exceptions\RequestException::class);
77
$MmsMessage = new \MessageBird\Objects\MmsMessage();
88

99
$this->mockClient->expects($this->once())
@@ -64,7 +64,7 @@ public function testListMms()
6464

6565
public function testDeleteMms()
6666
{
67-
$this->expectException('MessageBird\Exceptions\RequestException');
67+
$this->expectException(\MessageBird\Exceptions\RequestException::class);
6868
$this->mockClient->expects($this->exactly(2))
6969
->method('performHttpRequest')
7070
->with('DELETE', 'mms/message_id', null, null)
@@ -81,7 +81,7 @@ public function testDeleteMms()
8181

8282
public function testReadMms()
8383
{
84-
$this->expectException('MessageBird\Exceptions\RequestException');
84+
$this->expectException(\MessageBird\Exceptions\RequestException::class);
8585
$dummyMessage = $this->generateDummyMessage();
8686

8787
$this->mockClient->expects($this->exactly(2))

tests/integration/verify/VerifyTest.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ protected function setUp(): void
99

1010
public function testGenerateOtp()
1111
{
12-
$this->expectException('MessageBird\Exceptions\ServerException');
12+
$this->expectException(\MessageBird\Exceptions\ServerException::class);
1313
$Verify = new \MessageBird\Objects\Verify();
1414
$Verify->recipient = 31612345678;
1515
$Verify->reference = "Yoloswag3000";
@@ -21,7 +21,7 @@ public function testGenerateOtp()
2121

2222
public function testVerifyOtp()
2323
{
24-
$this->expectException('MessageBird\Exceptions\ServerException');
24+
$this->expectException(\MessageBird\Exceptions\ServerException::class);
2525
$Verify = new \MessageBird\Objects\Verify();
2626
$Verify->recipient = 31612345678;
2727
$Verify->reference = 'Yoloswag3000';

0 commit comments

Comments
 (0)