Skip to content

Commit ca7bad7

Browse files
author
Lucas Michot
authored
Merge branch 'master' into feature/short-array-syntax
2 parents d9feb88 + 3d832fa commit ca7bad7

File tree

5 files changed

+13
-7
lines changed

5 files changed

+13
-7
lines changed

composer.json

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,15 @@
1010
"email": "[email protected]"
1111
}
1212
],
13+
"support": {
14+
"docs": "https://developers.messagebird.com/api",
15+
"issues": "https://github.com/messagebird/php-rest-api/issues",
16+
"source": "https://github.com/messagebird/php-rest-api"
17+
},
1318
"require": {
1419
"php": ">=7.0",
15-
"ext-curl": "*"
20+
"ext-curl": "*",
21+
"ext-json": "*"
1622
},
1723
"require-dev": {
1824
"phpunit/phpunit": "^6.0|^7.5"

examples/lookup-hlr-view.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
$poolCount = 10;
1818
while($poolCount--) {
1919
$hlr = $MessageBird->lookupHlr->read($Hlr->msisdn);
20-
if ($hlr->status != \MessageBird\Objects\Hlr::STATUS_SENT) {
20+
if ($hlr->status !== \MessageBird\Objects\Hlr::STATUS_SENT) {
2121
// we have something
2222
var_dump($hlr);
2323
break;

src/MessageBird/Objects/Message.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -153,10 +153,10 @@ public function setPremiumSms($shortcode, $keyword, $tariff, $mid = null, $membe
153153
$this->typeDetails['shortcode'] = $shortcode;
154154
$this->typeDetails['keyword'] = $keyword;
155155
$this->typeDetails['tariff'] = $tariff;
156-
if ($mid != null) {
156+
if ($mid !== null) {
157157
$this->typeDetails['mid'] = $mid;
158158
}
159-
if ($member != null) {
159+
if ($member !== null) {
160160
$this->typeDetails['member'] = $member;
161161
}
162162

src/MessageBird/Resources/Lookup.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ public function read($phoneNumber = null, $countryCode = null)
4141
throw new InvalidArgumentException('The phone number cannot be empty.');
4242
}
4343
$query = null;
44-
if ($countryCode != null) {
44+
if ($countryCode !== null) {
4545
$query = ["countryCode" => $countryCode];
4646
}
4747
$ResourceName = $this->resourceName . '/' . $phoneNumber;

src/MessageBird/Resources/LookupHlr.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ public function create($hlr, $countryCode = null)
4242
}
4343

4444
$query = null;
45-
if ($countryCode != null) {
45+
if ($countryCode !== null) {
4646
$query = ["countryCode" => $countryCode];
4747
}
4848
$ResourceName = $this->resourceName . '/' . ($hlr->msisdn) . '/hlr' ;
@@ -67,7 +67,7 @@ public function read($phoneNumber = null, $countryCode = null)
6767
}
6868

6969
$query = null;
70-
if ($countryCode != null) {
70+
if ($countryCode !== null) {
7171
$query = ["countryCode" => $countryCode];
7272
}
7373
$ResourceName = $this->resourceName . '/' . $phoneNumber . '/hlr' ;

0 commit comments

Comments
 (0)