From d23d387910a8b35b03e90203adf26485b0849539 Mon Sep 17 00:00:00 2001 From: Dennis van der Vliet Date: Tue, 18 Jan 2022 16:14:08 +0100 Subject: [PATCH 1/2] Pin psalm version --- .github/workflows/psalm.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/psalm.yml b/.github/workflows/psalm.yml index a64cb3eb..729e3dc0 100644 --- a/.github/workflows/psalm.yml +++ b/.github/workflows/psalm.yml @@ -16,4 +16,4 @@ jobs: - uses: actions/checkout@v2 - name: Psalm – Static Analysis for PHP - uses: docker://vimeo/psalm-github-actions + uses: docker://vimeo/psalm-github-actions:v4 From fcba3cd5b36413e635d49a7a34f4cd7eb2564b7d Mon Sep 17 00:00:00 2001 From: Dennis van der Vliet Date: Tue, 18 Jan 2022 16:19:32 +0100 Subject: [PATCH 2/2] Pin psalm to 4.18.1 On every pull request we run psalm using a GitHub action. The GitHub action was using the `latest` version of psalm. On this [1] PR that resulted in psalm passing locally but breaking in the PR. This pins the version of psalm in composer and in the GitHub action to 4.18.1. [1] https://github.com/messagebird/php-rest-api/pull/186 --- .github/workflows/psalm.yml | 2 +- composer.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/psalm.yml b/.github/workflows/psalm.yml index 729e3dc0..60915c4c 100644 --- a/.github/workflows/psalm.yml +++ b/.github/workflows/psalm.yml @@ -16,4 +16,4 @@ jobs: - uses: actions/checkout@v2 - name: Psalm – Static Analysis for PHP - uses: docker://vimeo/psalm-github-actions:v4 + uses: docker://vimeo/psalm-github-actions:4.18.1 diff --git a/composer.json b/composer.json index 8daca80e..38af1231 100644 --- a/composer.json +++ b/composer.json @@ -23,7 +23,7 @@ }, "require-dev": { "phpunit/phpunit": "^8.0|^9.0", - "vimeo/psalm": "^4.6" + "vimeo/psalm": "4.18.1" }, "autoload": { "psr-4": {