Skip to content

broken on Google App Engine #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mobileink opened this issue Mar 31, 2016 · 5 comments
Closed

broken on Google App Engine #227

mobileink opened this issue Mar 31, 2016 · 5 comments

Comments

@mobileink
Copy link

FYI the latest version uses https://github.com/fge/msg-simple which uses threads in a way that is disallowed on GAE. I don't have time to adapt the code to use appengine's ThreadManager, but the offending line in the stacktrace, in case you're interested, is

com.github.fge.msgsimple.provider.LoadingMessageSourceProvider$1.newThread(LoadingMessageSourceProvider.java:91)

@ikitommi
Copy link
Member

ikitommi commented Apr 4, 2016

Thanks. We could lazily require the FGE (only when needed) to support this.

@mobileink
Copy link
Author

Not a pressing issue for me at the moment but it would be nice to have compojure-api on gae again. it worked just fine previously.

@Deraen
Copy link
Member

Deraen commented Apr 4, 2016

The problem dependency: metosin/ring-swagger -> metosin/scjsv -> com.github.fge/json-schema-validator -> com.github.fge/json-schema-core -> com.github.fge/uri-template -> com.github.fge/msg-simple

@ikitommi
Copy link
Member

Should work now with the following:

[metosin/compojure-api "1.0.3-SNAPSHOT" :exclusions [[metosin/scjsv]]]

You can't call compojure.api.swagger/validate on your apis on GAE as it lazily tries to load the FGE and it's excluded. But, that's intended for testing anyways.

@ikitommi
Copy link
Member

Added a short wiki-page about GAE, feel free to fix and add (any relevant) information the page:

https://github.com/metosin/compojure-api/wiki/Google-app-engine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants