Skip to content

Commit 260f937

Browse files
committed
doc: add req for sec wg review in some cases
Some recent dicsussions point to it being a good idea to require reviews from the security-wg for security related PRs. See nodejs#21766 Add this requirement to the collaborator guide.
1 parent fe67287 commit 260f937

File tree

1 file changed

+11
-0
lines changed

1 file changed

+11
-0
lines changed

COLLABORATOR_GUIDE.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
- [Breaking Changes to Internal Elements](#breaking-changes-to-internal-elements)
2121
- [When Breaking Changes Actually Break Things](#when-breaking-changes-actually-break-things)
2222
- [Reverting commits](#reverting-commits)
23+
- [Additions to the Cryptography and Security APIs](#additions-to-the-cryptography-and-security-apis)
2324
- [Introducing New Modules](#introducing-new-modules)
2425
- [Deprecations](#deprecations)
2526
- [Involving the TSC](#involving-the-tsc)
@@ -378,6 +379,16 @@ multiple commits. Commit metadata and the reason for the revert should be
378379
appended. Commit message rules about line length and subsystem can be ignored.
379380
A Pull Request should be raised and approved like any other change.
380381

382+
### Additions to the Cryptography and Security APIs
383+
384+
Semver-minor commits that add or change cryptograpy/security APIs should be
385+
treated with extra care. Due to the potential impact, it is important that
386+
these APIs be constructed to reduce the potential for incorrect
387+
usage.
388+
389+
These commits must have an approval from at least one member from the
390+
[security working group](https://github.com/nodejs/security-wg).
391+
381392
### Introducing New Modules
382393

383394
Semver-minor commits that introduce new core modules should be treated with

0 commit comments

Comments
 (0)