Skip to content

Commit 43c3a48

Browse files
ilonatommymichaelgsharp
authored andcommitted
[wasm] Switch off HybridGlobalization lane on v8 on CI (dotnet#101671)
* Stop testing on v8. * Try to block by scenario, * Limit scenarios. This reverts commit 38f64f7.
1 parent 000c7c8 commit 43c3a48

File tree

3 files changed

+16
-2
lines changed

3 files changed

+16
-2
lines changed

eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,6 @@ jobs:
197197
isWasmOnlyBuild: ${{ parameters.isWasmOnlyBuild }}
198198
alwaysRun: true
199199
scenarios:
200-
- WasmTestOnV8
201200
- WasmTestOnChrome
202201
- WasmTestOnFirefox
203202
- WasmTestOnNodeJS
@@ -215,7 +214,6 @@ jobs:
215214
isWasmOnlyBuild: ${{ parameters.isWasmOnlyBuild }}
216215
alwaysRun: true
217216
scenarios:
218-
- WasmTestOnV8
219217
- WasmTestOnChrome
220218
- WasmTestOnNodeJS
221219

src/libraries/System.Runtime/tests/System.Globalization.Calendars.Tests/Hybrid/System.Globalization.Calendars.Hybrid.WASM.Tests.csproj

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,14 @@
44
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
55
<TestRuntime>true</TestRuntime>
66
<HybridGlobalization>true</HybridGlobalization>
7+
</PropertyGroup>
8+
<PropertyGroup Condition="'$(TargetOS)' == 'browser'">
9+
<!-- This doesn't run on V8 because https://github.com/dotnet/runtime/pull/101671 -->
10+
<Scenario>WasmTestOnChrome</Scenario>
11+
<TestArchiveTestsRoot>$(TestArchiveRoot)browserornodejs/</TestArchiveTestsRoot>
12+
<TestArchiveTestsDir>$(TestArchiveTestsRoot)$(OSPlatformConfig)/</TestArchiveTestsDir>
13+
<DefineConstants>$(DefineConstants);TARGET_BROWSER</DefineConstants>
14+
<XunitShowProgress>true</XunitShowProgress>
715
</PropertyGroup>
816
<ItemGroup>
917
<Compile Include="..\System\Globalization\CalendarTestBase.cs" />

src/libraries/System.Runtime/tests/System.Globalization.Tests/Hybrid/System.Globalization.Hybrid.WASM.Tests.csproj

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,14 @@
66
<IncludeRemoteExecutor>true</IncludeRemoteExecutor>
77
<HybridGlobalization>true</HybridGlobalization>
88
</PropertyGroup>
9+
<PropertyGroup Condition="'$(TargetOS)' == 'browser'">
10+
<!-- This doesn't run on V8 because https://github.com/dotnet/runtime/pull/101671 -->
11+
<Scenario>WasmTestOnChrome</Scenario>
12+
<TestArchiveTestsRoot>$(TestArchiveRoot)browserornodejs/</TestArchiveTestsRoot>
13+
<TestArchiveTestsDir>$(TestArchiveTestsRoot)$(OSPlatformConfig)/</TestArchiveTestsDir>
14+
<DefineConstants>$(DefineConstants);TARGET_BROWSER</DefineConstants>
15+
<XunitShowProgress>true</XunitShowProgress>
16+
</PropertyGroup>
917
<ItemGroup>
1018
<Compile Include="..\CompareInfo\CompareInfoTestsBase.cs" />
1119
<Compile Include="..\System\Globalization\TextInfoTests.cs" />

0 commit comments

Comments
 (0)