Address feedback

Author: captainsafia

src/Microsoft.OpenApi/Extensions/StringExtensions.cs

@@ -17,7 +17,6 @@ public static class StringExtensions
         /// Gets the enum value based on the given enum type and display name.
         /// </summary>
         /// <param name="displayName">The display name.</param>
-        [UnconditionalSuppressMessage("Trimming", "IL2075", Justification = "Fields are never trimmed for enum types.")]
         public static T GetEnumFromDisplayName<[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicFields)] T>(this string displayName)
         {
             var type = typeof(T);

test/Microsoft.OpenApi.Tests/Attributes/DisplayAttributeTests.cs

@@ -1,4 +1,5 @@
-using Microsoft.OpenApi.Attributes;
+using System;
+using Microsoft.OpenApi.Attributes;
 using Microsoft.OpenApi.Extensions;
 using Xunit;
 
@@ -14,6 +15,17 @@ public enum ApiLevel
         Corporate = 3
     }
 
+    [Flags]
+    public enum UserType
+    {
+        [DisplayAttribute("admin")]
+        Admin = 1,
+        [DisplayAttribute("editor")]
+        Editor = 2,
+        [DisplayAttribute("publisher")]
+        Publisher = 3
+    }
+
     public class DisplayAttributeTests
     {
         [Theory]
@@ -24,5 +36,23 @@ public void GetDisplayNameExtensionShouldUseDisplayAttribute(ApiLevel apiLevel,
         {
             Assert.Equal(expected, apiLevel.GetDisplayName());          
         }
+
+        [Theory]
+        [InlineData(ApiLevel.Private,"private")]
+        [InlineData(ApiLevel.Public, "public")]
+        [InlineData(ApiLevel.Corporate, "corporate")]
+        public void GetEnumFromDisplayNameShouldReturnEnumValue(ApiLevel expected, string displayName)
+        {
+            Assert.Equal(expected, displayName.GetEnumFromDisplayName<ApiLevel>());
+        }
+
+        [Theory]
+        [InlineData(UserType.Admin,"admin")]
+        [InlineData(UserType.Publisher, "publisher")]
+        [InlineData(UserType.Editor, "editor")]
+        public void GetEnumFromDisplayNameShouldReturnEnumValueForFlagsEnum(UserType expected, string displayName)
+        {
+            Assert.Equal(expected, displayName.GetEnumFromDisplayName<UserType>());
+        }
     }
 }

test/Microsoft.OpenApi.Trimming.Tests/Program.cs

@@ -1,2 +1 @@
-// See https://aka.ms/new-console-template for more information
-Console.WriteLine("Hello, World!");
+Console.WriteLine("Hello, World!");