Merge pull request #275 from sidraval/master

fix: Type of `this` for XMLHttpRequest properties

Author: mhegazy

baselines/dom.generated.d.ts

@@ -13827,13 +13827,13 @@ interface XMLHttpRequestEventTargetEventMap {
 }
 
 interface XMLHttpRequestEventTarget {
-    onabort: (this: XMLHttpRequestEventTarget, ev: Event) => any;
-    onerror: (this: XMLHttpRequestEventTarget, ev: ErrorEvent) => any;
-    onload: (this: XMLHttpRequestEventTarget, ev: Event) => any;
-    onloadend: (this: XMLHttpRequestEventTarget, ev: ProgressEvent) => any;
-    onloadstart: (this: XMLHttpRequestEventTarget, ev: Event) => any;
-    onprogress: (this: XMLHttpRequestEventTarget, ev: ProgressEvent) => any;
-    ontimeout: (this: XMLHttpRequestEventTarget, ev: ProgressEvent) => any;
+    onabort: (this: XMLHttpRequest, ev: Event) => any;
+    onerror: (this: XMLHttpRequest, ev: ErrorEvent) => any;
+    onload: (this: XMLHttpRequest, ev: Event) => any;
+    onloadend: (this: XMLHttpRequest, ev: ProgressEvent) => any;
+    onloadstart: (this: XMLHttpRequest, ev: Event) => any;
+    onprogress: (this: XMLHttpRequest, ev: ProgressEvent) => any;
+    ontimeout: (this: XMLHttpRequest, ev: ProgressEvent) => any;
     addEventListener<K extends keyof XMLHttpRequestEventTargetEventMap>(type: K, listener: (this: XMLHttpRequestEventTarget, ev: XMLHttpRequestEventTargetEventMap[K]) => any, useCapture?: boolean): void;
     addEventListener(type: string, listener: EventListenerOrEventListenerObject, useCapture?: boolean): void;
 }

baselines/webworker.generated.d.ts

@@ -1249,13 +1249,13 @@ interface XMLHttpRequestEventTargetEventMap {
 }
 
 interface XMLHttpRequestEventTarget {
-    onabort: (this: XMLHttpRequestEventTarget, ev: Event) => any;
-    onerror: (this: XMLHttpRequestEventTarget, ev: ErrorEvent) => any;
-    onload: (this: XMLHttpRequestEventTarget, ev: Event) => any;
-    onloadend: (this: XMLHttpRequestEventTarget, ev: ProgressEvent) => any;
-    onloadstart: (this: XMLHttpRequestEventTarget, ev: Event) => any;
-    onprogress: (this: XMLHttpRequestEventTarget, ev: ProgressEvent) => any;
-    ontimeout: (this: XMLHttpRequestEventTarget, ev: ProgressEvent) => any;
+    onabort: (this: XMLHttpRequest, ev: Event) => any;
+    onerror: (this: XMLHttpRequest, ev: ErrorEvent) => any;
+    onload: (this: XMLHttpRequest, ev: Event) => any;
+    onloadend: (this: XMLHttpRequest, ev: ProgressEvent) => any;
+    onloadstart: (this: XMLHttpRequest, ev: Event) => any;
+    onprogress: (this: XMLHttpRequest, ev: ProgressEvent) => any;
+    ontimeout: (this: XMLHttpRequest, ev: ProgressEvent) => any;
     addEventListener<K extends keyof XMLHttpRequestEventTargetEventMap>(type: K, listener: (this: XMLHttpRequestEventTarget, ev: XMLHttpRequestEventTargetEventMap[K]) => any, useCapture?: boolean): void;
     addEventListener(type: string, listener: EventListenerOrEventListenerObject, useCapture?: boolean): void;
 }

inputfiles/overridingTypes.json

@@ -113,6 +113,54 @@
         "name": "pixelStorei",
         "signatures": ["pixelStorei(pname: number, param: number | boolean): void"]
     },
+    {
+        "kind": "property",
+        "interface": "XMLHttpRequestEventTarget",
+        "name": "onload",
+        "type": "(this: XMLHttpRequest, ev: Event) => any"
+    },
+    {
+        "kind": "property",
+        "interface": "XMLHttpRequestEventTarget",
+        "name": "onabort",
+        "type": "(this: XMLHttpRequest, ev: Event) => any"
+    },
+    {
+        "kind": "property",
+        "interface": "XMLHttpRequestEventTarget",
+        "name": "onerror",
+        "type": "(this: XMLHttpRequest, ev: ErrorEvent) => any"
+    },
+    {
+        "kind": "property",
+        "interface": "XMLHttpRequestEventTarget",
+        "name": "onloadend",
+        "type": "(this: XMLHttpRequest, ev: ProgressEvent) => any"
+    },
+    {
+        "kind": "property",
+        "interface": "XMLHttpRequestEventTarget",
+        "name": "onloadstart",
+        "type": "(this: XMLHttpRequest, ev: Event) => any"
+    },
+    {
+        "kind": "property",
+        "interface": "XMLHttpRequestEventTarget",
+        "name": "onprogress",
+        "type": "(this: XMLHttpRequest, ev: ProgressEvent) => any"
+    },
+    {
+        "kind": "property",
+        "interface": "XMLHttpRequestEventTarget",
+        "name": "onprogress",
+        "type": "(this: XMLHttpRequest, ev: ProgressEvent) => any"
+    },
+    {
+        "kind": "property",
+        "interface": "XMLHttpRequestEventTarget",
+        "name": "ontimeout",
+        "type": "(this: XMLHttpRequest, ev: ProgressEvent) => any"
+    },
     {
         "kind": "method",
         "interface": "XMLHttpRequest",