Moves removing the static abort function to a part of the deploy process

Author: orta

baselines/dom.generated.d.ts

@@ -1912,6 +1912,7 @@ interface AbortSignal extends EventTarget {
 declare var AbortSignal: {
     prototype: AbortSignal;
     new(): AbortSignal;
+    abort(): AbortSignal;
 };
 
 interface AbstractRange {

baselines/serviceworker.generated.d.ts

@@ -697,6 +697,7 @@ interface AbortSignal extends EventTarget {
 declare var AbortSignal: {
     prototype: AbortSignal;
     new(): AbortSignal;
+    abort(): AbortSignal;
 };
 
 interface AbstractWorkerEventMap {

baselines/sharedworker.generated.d.ts

@@ -669,6 +669,7 @@ interface AbortSignal extends EventTarget {
 declare var AbortSignal: {
     prototype: AbortSignal;
     new(): AbortSignal;
+    abort(): AbortSignal;
 };
 
 interface AbstractWorkerEventMap {

baselines/webworker.generated.d.ts

@@ -703,6 +703,7 @@ interface AbortSignal extends EventTarget {
 declare var AbortSignal: {
     prototype: AbortSignal;
     new(): AbortSignal;
+    abort(): AbortSignal;
 };
 
 interface AbstractWorkerEventMap {

deploy/README.md

@@ -1,3 +1,9 @@
 ## Deploys
 
-We want to generate @types/xyz
+We want to take the `d.ts` files inside `generated` into a set of different `@types` packages. This infra all lives inside these files as multiple steps. For debugging you mostly want to run:
+
+```sh
+node deploy/createTypesPackages.js
+```
+
+Then look at `deploy/generated` to see the set of NPM packages. 

deploy/createTypesPackages.js

@@ -90,6 +90,7 @@ const go = async () => {
     });
 
     prependAutoImports(pkg, packagePath);
+    postProcessDTSFiles(pkg, packagePath);
 
     // Setup the files in the repo
     const newPkgJSON = await updatePackageJSON(pkg, packagePath);
@@ -188,6 +189,30 @@ function prependAutoImports(pkg, packagePath) {
   fs.writeFileSync(index, `${toPrepend}\n\n${indexText}`);
 }
 
+/**
+ * Handles any post-processing we do for deployment.
+ * @param {Package} pkg
+ * @param {URL} packagePath
+ */
+function postProcessDTSFiles(pkg, packagePath) {
+  iterateThroughFiles((content) => {
+    return content.replace(
+      "abort(): AbortSignal;",
+      "// abort(): AbortSignal; - To be re-added in the future"
+    );
+  });
+
+  /** @param {(str:string) => string} contentReplacer */
+  function iterateThroughFiles(contentReplacer) {
+    pkg.files.forEach((fileRef) => {
+      const dtsFileURL = new URL(fileRef.to, packagePath);
+      let dtsContent = fs.readFileSync(dtsFileURL, "utf-8");
+      dtsContent = contentReplacer(dtsContent);
+      fs.writeFileSync(dtsFileURL, dtsContent);
+    });
+  }
+}
+
 if (process.argv[1] === fileURLToPath(import.meta.url)) {
   await go();
 }

inputfiles/removedTypes.jsonc

@@ -166,14 +166,6 @@
             "Text": {
                 "implements": ["GeometryUtils"]
             },
-            // This is hard to get in sync with @types/node
-            "AbortSignal": {
-                "methods": {
-                    "method": {
-                        "abort": null
-                    }
-                }
-            },
             "WebGLBuffer": {
                 "extends": null
             },