From f6f48a0bf79b8401fdd7420040bd9190ed953f30 Mon Sep 17 00:00:00 2001 From: Chris Morgan Date: Sat, 16 Sep 2017 16:45:05 +1000 Subject: [PATCH 1/2] Fix MediaTrackConstraintSet echoCancellation typo MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit echoCancelation → echoCancellation When Edge fixes its typo, this should be reverted. Fixes #251. --- baselines/dom.generated.d.ts | 2 +- inputfiles/addedTypes.json | 6 ++++++ inputfiles/removedTypes.json | 5 +++++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/baselines/dom.generated.d.ts b/baselines/dom.generated.d.ts index f0f10ef66..23e82c440 100644 --- a/baselines/dom.generated.d.ts +++ b/baselines/dom.generated.d.ts @@ -296,9 +296,9 @@ interface MediaTrackConstraints extends MediaTrackConstraintSet { } interface MediaTrackConstraintSet { + echoCancellation?: boolean | ConstrainBooleanParameters; aspectRatio?: number | ConstrainDoubleRange; deviceId?: string | string[] | ConstrainDOMStringParameters; - echoCancelation?: boolean | ConstrainBooleanParameters; facingMode?: string | string[] | ConstrainDOMStringParameters; frameRate?: number | ConstrainDoubleRange; groupId?: string | string[] | ConstrainDOMStringParameters; diff --git a/inputfiles/addedTypes.json b/inputfiles/addedTypes.json index 7138f0871..692b92a43 100644 --- a/inputfiles/addedTypes.json +++ b/inputfiles/addedTypes.json @@ -1764,5 +1764,11 @@ "constructorSignatures": ["new(): HTMLSummaryElement"], "extends": "HTMLElement", "flavor": "DOM" + }, + { + "kind": "property", + "interface": "MediaTrackConstraintSet", + "name": "echoCancellation?", + "type": "boolean | ConstrainBooleanParameters" } ] diff --git a/inputfiles/removedTypes.json b/inputfiles/removedTypes.json index 9168ace44..37c87989d 100644 --- a/inputfiles/removedTypes.json +++ b/inputfiles/removedTypes.json @@ -77,5 +77,10 @@ { "kind": "typedef", "name": "JSON" + }, + { + "kind": "property", + "interface": "MediaTrackConstraintSet", + "name": "echoCancelation" } ] From c4985c1e80072b92decc6caa9e5f23b53218930a Mon Sep 17 00:00:00 2001 From: Chris Morgan Date: Sat, 16 Sep 2017 16:46:28 +1000 Subject: [PATCH 2/2] Add MediaTrackConstraintSet.{channelCount,latency} I have not included `autoGainControl` or `noiseSuppression` in this commit as they are only in the working draft, not the current candidate recommendation. Fixes #286. --- baselines/dom.generated.d.ts | 2 ++ inputfiles/addedTypes.json | 12 ++++++++++++ 2 files changed, 14 insertions(+) diff --git a/baselines/dom.generated.d.ts b/baselines/dom.generated.d.ts index 23e82c440..ef7a53717 100644 --- a/baselines/dom.generated.d.ts +++ b/baselines/dom.generated.d.ts @@ -297,6 +297,8 @@ interface MediaTrackConstraints extends MediaTrackConstraintSet { interface MediaTrackConstraintSet { echoCancellation?: boolean | ConstrainBooleanParameters; + channelCount?: long | ConstrainLongRange; + latency?: double | ConstrainDoubleRange; aspectRatio?: number | ConstrainDoubleRange; deviceId?: string | string[] | ConstrainDOMStringParameters; facingMode?: string | string[] | ConstrainDOMStringParameters; diff --git a/inputfiles/addedTypes.json b/inputfiles/addedTypes.json index 692b92a43..87c4edd05 100644 --- a/inputfiles/addedTypes.json +++ b/inputfiles/addedTypes.json @@ -1770,5 +1770,17 @@ "interface": "MediaTrackConstraintSet", "name": "echoCancellation?", "type": "boolean | ConstrainBooleanParameters" + }, + { + "kind": "property", + "interface": "MediaTrackConstraintSet", + "name": "channelCount?", + "type": "long | ConstrainLongRange" + }, + { + "kind": "property", + "interface": "MediaTrackConstraintSet", + "name": "latency?", + "type": "double | ConstrainDoubleRange" } ]