Skip to content

@typescript/vfs type declaration file is broken #2953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JeanMeche opened this issue Oct 5, 2023 · 0 comments · Fixed by #3140
Closed

@typescript/vfs type declaration file is broken #2953

JeanMeche opened this issue Oct 5, 2023 · 0 comments · Fixed by #3140

Comments

@JeanMeche
Copy link

I'd like to reopen #2742, it isn't website related but it concerns the @typescript/vfs.

@typescript/vfs's index.d.ts file makes references to things that don't exist in it's scope.

Expected behavior:

> tsc --noEmit doesn't give any error for this module.

Actual behavior:

There are 3 errors:

> tsc --noEmit

node_modules/.pnpm/@[email protected]/node_modules/@typescript/vfs/dist/index.d.ts:57:140 - error TS2307: Cannot find module 'lz-string' or its corresponding type declarations.

57 export declare const createDefaultMapFromCDN: (options: CompilerOptions, version: string, cache: boolean, ts: TS, lzstring?: typeof import("lz-string"), fetcher?: typeof fetch, storer?: typeof localStorage) => Promise<Map<string, string>>;
                                                                                                                                              ~~~~~~~~~~~

node_modules/.pnpm/@[email protected]/node_modules/@typescript/vfs/dist/index.d.ts:57:171 - error TS2552: Cannot find name 'fetch'. Did you mean 'fetcher'?

57 export declare const createDefaultMapFromCDN: (options: CompilerOptions, version: string, cache: boolean, ts: TS, lzstring?: typeof import("lz-string"), fetcher?: typeof fetch, storer?: typeof localStorage) => Promise<Map<string, string>>;
                                                                                                                                                                             ~~~~~

  node_modules/.pnpm/@[email protected]/node_modules/@typescript/vfs/dist/index.d.ts:57:154
    57 export declare const createDefaultMapFromCDN: (options: CompilerOptions, version: string, cache: boolean, ts: TS, lzstring?: typeof import("lz-string"), fetcher?: typeof fetch, storer?: typeof localStorage) => Promise<Map<string, string>>;
                                                                                                                                                                ~~~~~~~~~~~~~~~~~~~~~~
    'fetcher' is declared here.

node_modules/.pnpm/@[email protected]/node_modules/@typescript/vfs/dist/index.d.ts:57:194 - error TS2304: Cannot find name 'localStorage'.

57 export declare const createDefaultMapFromCDN: (options: CompilerOptions, version: string, cache: boolean, ts: TS, lzstring?: typeof import("lz-string"), fetcher?: typeof fetch, storer?: typeof localStorage) => Promise<Map<string, string>>;
                                                                                                                                                                                                    ~~~~~~~~~~~~


Found 3 errors in the same file, starting at: node_modules/.pnpm/@[email protected]/node_modules/@typescript/vfs/dist/index.d.ts:57

 ELIFECYCLE  Command failed with exit code 2.

typeof fetch is no-longer an issue since Node18, but others still are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant