Skip to content

Commit 3d0b2b8

Browse files
committed
address PR feedback
1 parent 2046dce commit 3d0b2b8

File tree

2 files changed

+8
-10
lines changed

2 files changed

+8
-10
lines changed

src/compiler/utilities.ts

+6-8
Original file line numberDiff line numberDiff line change
@@ -11418,14 +11418,10 @@ export function createNameResolver({
1141811418
}
1141911419
break;
1142011420
case SyntaxKind.Parameter: {
11421-
const param = location as ParameterDeclaration;
11422-
if (lastLocation === param.name) {
11423-
lastSelfReferenceLocation = param;
11424-
}
1142511421
if (
1142611422
lastLocation && (
11427-
lastLocation === param.initializer ||
11428-
lastLocation === param.name && isBindingPattern(lastLocation)
11423+
lastLocation === (location as ParameterDeclaration).initializer ||
11424+
lastLocation === (location as ParameterDeclaration).name && isBindingPattern(lastLocation)
1142911425
)
1143011426
) {
1143111427
if (!associatedDeclarationForContainingInitializerOrBindingName) {
@@ -11466,7 +11462,7 @@ export function createNameResolver({
1146611462
}
1146711463
break;
1146811464
}
11469-
if (isSelfReferenceLocation(location)) {
11465+
if (isSelfReferenceLocation(location, lastLocation)) {
1147011466
lastSelfReferenceLocation = location;
1147111467
}
1147211468
lastLocation = location;
@@ -11608,8 +11604,10 @@ export function createNameResolver({
1160811604
| TypeAliasDeclaration
1160911605
| ModuleDeclaration;
1161011606

11611-
function isSelfReferenceLocation(node: Node): node is SelfReferenceLocation {
11607+
function isSelfReferenceLocation(node: Node, lastLocation: Node | undefined): node is SelfReferenceLocation {
1161211608
switch (node.kind) {
11609+
case SyntaxKind.Parameter:
11610+
return !!lastLocation && lastLocation === (node as ParameterDeclaration).name;
1161311611
case SyntaxKind.FunctionDeclaration:
1161411612
case SyntaxKind.ClassDeclaration:
1161511613
case SyntaxKind.InterfaceDeclaration:

tests/baselines/reference/noUnusedLocals_potentialPredicateUnusedParam.types

+2-2
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@ function potentialPredicateUnusedParam(a: unknown) {
1515
>Math.random() : number
1616
> : ^^^^^^
1717
>Math.random : () => number
18-
> : ^^^^^^^^^^^^
18+
> : ^^^^^^
1919
>Math : Math
2020
> : ^^^^
2121
>random : () => number
22-
> : ^^^^^^^^^^^^
22+
> : ^^^^^^
2323
}
2424

0 commit comments

Comments
 (0)