Merge pull request #7409 from anilanar/allowOutWithNoEmit

Fix #7397: Remove error checks for noEmit and out* compiler options combined.

Author: mhegazy

src/compiler/program.ts

@@ -1746,24 +1746,7 @@ namespace ts {
                 }
             }
 
-            if (options.noEmit) {
-                if (options.out) {
-                    programDiagnostics.add(createCompilerDiagnostic(Diagnostics.Option_0_cannot_be_specified_with_option_1, "noEmit", "out"));
-                }
-
-                if (options.outFile) {
-                    programDiagnostics.add(createCompilerDiagnostic(Diagnostics.Option_0_cannot_be_specified_with_option_1, "noEmit", "outFile"));
-                }
-
-                if (options.outDir) {
-                    programDiagnostics.add(createCompilerDiagnostic(Diagnostics.Option_0_cannot_be_specified_with_option_1, "noEmit", "outDir"));
-                }
-
-                if (options.declaration) {
-                    programDiagnostics.add(createCompilerDiagnostic(Diagnostics.Option_0_cannot_be_specified_with_option_1, "noEmit", "declaration"));
-                }
-            }
-            else if (options.allowJs && options.declaration) {
+            if (!options.noEmit && options.allowJs && options.declaration) {
                 programDiagnostics.add(createCompilerDiagnostic(Diagnostics.Option_0_cannot_be_specified_with_option_1, "allowJs", "declaration"));
             }
 

tests/baselines/reference/compilerOptionsDeclarationAndNoEmit.symbols

@@ -0,0 +1,6 @@
+=== tests/cases/compiler/a.ts ===
+
+class c {
+>c : Symbol(c, Decl(a.ts, 0, 0))
+}
+

tests/baselines/reference/compilerOptionsDeclarationAndNoEmit.types

@@ -0,0 +1,6 @@
+=== tests/cases/compiler/a.ts ===
+
+class c {
+>c : c
+}
+

tests/baselines/reference/compilerOptionsOutAndNoEmit.symbols

@@ -0,0 +1,6 @@
+=== tests/cases/compiler/a.ts ===
+
+class c {
+>c : Symbol(c, Decl(a.ts, 0, 0))
+}
+

tests/baselines/reference/compilerOptionsOutAndNoEmit.types

@@ -0,0 +1,6 @@
+=== tests/cases/compiler/a.ts ===
+
+class c {
+>c : c
+}
+

tests/baselines/reference/compilerOptionsOutDirAndNoEmit.symbols

@@ -0,0 +1,6 @@
+=== tests/cases/compiler/a.ts ===
+
+class c {
+>c : Symbol(c, Decl(a.ts, 0, 0))
+}
+

tests/baselines/reference/compilerOptionsOutDirAndNoEmit.types

@@ -0,0 +1,6 @@
+=== tests/cases/compiler/a.ts ===
+
+class c {
+>c : c
+}
+

tests/baselines/reference/compilerOptionsOutFileAndNoEmit.symbols

@@ -0,0 +1,6 @@
+=== tests/cases/compiler/a.ts ===
+
+class c {
+>c : Symbol(c, Decl(a.ts, 0, 0))
+}
+

tests/baselines/reference/compilerOptionsOutFileAndNoEmit.types

@@ -0,0 +1,6 @@
+=== tests/cases/compiler/a.ts ===
+
+class c {
+>c : c
+}
+

tests/cases/compiler/compilerOptionsDeclarationAndNoEmit.ts

@@ -0,0 +1,6 @@
+// @declaration: true
+// @noEmit: true
+// @fileName: a.ts
+
+class c {
+}

tests/cases/compiler/compilerOptionsOutAndNoEmit.ts

@@ -0,0 +1,6 @@
+// @out: outDir
+// @noEmit: true
+// @fileName: a.ts
+
+class c {
+}

tests/cases/compiler/compilerOptionsOutDirAndNoEmit.ts

@@ -0,0 +1,6 @@
+// @outDir: outDir
+// @noEmit: true
+// @fileName: a.ts
+
+class c {
+}

tests/cases/compiler/compilerOptionsOutFileAndNoEmit.ts

@@ -0,0 +1,6 @@
+// @outFile: a.js
+// @noEmit: true
+// @fileName: a.ts
+
+class c {
+}