Revert recognizing invalid forms as type-only

Author: andrewbranch

src/compiler/checker.ts

@@ -2457,12 +2457,7 @@ namespace ts {
                 const name = (specifier.propertyName ?? specifier.name).escapedText;
                 const exportSymbol = getExportsOfSymbol(symbol).get(name);
                 const resolved = resolveSymbol(exportSymbol, dontResolveAlias);
-                if (!markSymbolOfAliasDeclarationIfTypeOnly(specifier, exportSymbol, resolved, /*overwriteEmpty*/ false)) {
-                    if (resolved && symbol.exports && !symbol.exports.has(name)) {
-                        // `resolved` must have come from a namespace export, which could be `export type *`
-                        markSymbolOfAliasDeclarationIfTypeOnly(specifier, symbol.exports.get(InternalSymbolName.ExportStar), /*finalTarget*/ undefined, /*overwriteEmpty*/ true);
-                    }
-                }
+                markSymbolOfAliasDeclarationIfTypeOnly(specifier, exportSymbol, resolved, /*overwriteEmpty*/ false);
                 return resolved;
             }
         }
@@ -3272,7 +3267,6 @@ namespace ts {
                     const lookupTable = createMap<ExportCollisionTracker>() as ExportCollisionTrackerTable;
                     for (const node of exportStars.declarations) {
                         const resolvedModule = resolveExternalModuleName(node, (node as ExportDeclaration).moduleSpecifier!);
-                        markSymbolOfAliasDeclarationIfTypeOnly(node, resolvedModule, /*finalTarget*/ undefined, /*overwriteEmpty*/ false);
                         const exportedSymbols = visit(resolvedModule);
                         extendExportSymbols(
                             nestedSymbols,

src/compiler/utilitiesPublic.ts

@@ -1727,11 +1727,9 @@ namespace ts {
             case SyntaxKind.ExportSpecifier:
                 return (node as ImportOrExportSpecifier).parent.parent.isTypeOnly;
             case SyntaxKind.NamespaceImport:
-            case SyntaxKind.NamespaceExport:
-                return (node as NamespaceImport | NamespaceExport).parent.isTypeOnly;
+                return (node as NamespaceImport).parent.isTypeOnly;
             case SyntaxKind.ImportClause:
-            case SyntaxKind.ExportDeclaration:
-                return (node as ImportClause | ExportDeclaration).isTypeOnly;
+                return (node as ImportClause).isTypeOnly;
             default:
                 return false;
         }

tests/baselines/reference/exportNamespace4.errors.txt

@@ -1,7 +1,5 @@
 tests/cases/conformance/externalModules/typeOnly/b.ts(1,1): error TS1383: Only named exports may use 'export type'.
 tests/cases/conformance/externalModules/typeOnly/c.ts(1,1): error TS1383: Only named exports may use 'export type'.
-tests/cases/conformance/externalModules/typeOnly/d.ts(2,1): error TS1362: 'A' cannot be used as a value because it was exported using 'export type'.
-tests/cases/conformance/externalModules/typeOnly/e.ts(2,1): error TS1362: 'ns' cannot be used as a value because it was exported using 'export type'.
 
 
 ==== tests/cases/conformance/externalModules/typeOnly/a.ts (0 errors) ====
@@ -17,17 +15,11 @@ tests/cases/conformance/externalModules/typeOnly/e.ts(2,1): error TS1362: 'ns' c
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 !!! error TS1383: Only named exports may use 'export type'.
 
-==== tests/cases/conformance/externalModules/typeOnly/d.ts (1 errors) ====
+==== tests/cases/conformance/externalModules/typeOnly/d.ts (0 errors) ====
     import { A } from './b';
-    A; // Error
-    ~
-!!! error TS1362: 'A' cannot be used as a value because it was exported using 'export type'.
-!!! related TS1377 tests/cases/conformance/externalModules/typeOnly/b.ts:1:1: 'A' was exported here.
+    A;
 
-==== tests/cases/conformance/externalModules/typeOnly/e.ts (1 errors) ====
+==== tests/cases/conformance/externalModules/typeOnly/e.ts (0 errors) ====
     import { ns } from './c';
-    ns.A; // Error
-    ~~
-!!! error TS1362: 'ns' cannot be used as a value because it was exported using 'export type'.
-!!! related TS1377 tests/cases/conformance/externalModules/typeOnly/c.ts:1:13: 'ns' was exported here.
+    ns.A;
 

tests/baselines/reference/exportNamespace4.js

@@ -11,11 +11,11 @@ export type * as ns from './a'; // Grammar error
 
 //// [d.ts]
 import { A } from './b';
-A; // Error
+A;
 
 //// [e.ts]
 import { ns } from './c';
-ns.A; // Error
+ns.A;
 
 
 //// [a.js]
@@ -36,8 +36,10 @@ exports.__esModule = true;
 //// [d.js]
 "use strict";
 exports.__esModule = true;
-A; // Error
+var b_1 = require("./b");
+b_1.A;
 //// [e.js]
 "use strict";
 exports.__esModule = true;
-ns.A; // Error
+var c_1 = require("./c");
+c_1.ns.A;

tests/baselines/reference/exportNamespace4.symbols

@@ -13,14 +13,14 @@ export type * as ns from './a'; // Grammar error
 import { A } from './b';
 >A : Symbol(A, Decl(d.ts, 0, 8))
 
-A; // Error
+A;
 >A : Symbol(A, Decl(d.ts, 0, 8))
 
 === tests/cases/conformance/externalModules/typeOnly/e.ts ===
 import { ns } from './c';
 >ns : Symbol(ns, Decl(e.ts, 0, 8))
 
-ns.A; // Error
+ns.A;
 >ns.A : Symbol(ns.A, Decl(a.ts, 0, 0))
 >ns : Symbol(ns, Decl(e.ts, 0, 8))
 >A : Symbol(ns.A, Decl(a.ts, 0, 0))

tests/baselines/reference/exportNamespace4.types

@@ -13,14 +13,14 @@ export type * as ns from './a'; // Grammar error
 import { A } from './b';
 >A : typeof A
 
-A; // Error
+A;
 >A : typeof A
 
 === tests/cases/conformance/externalModules/typeOnly/e.ts ===
 import { ns } from './c';
 >ns : typeof ns
 
-ns.A; // Error
+ns.A;
 >ns.A : typeof ns.A
 >ns : typeof ns
 >A : typeof ns.A

tests/cases/conformance/externalModules/typeOnly/exportNamespace4.ts

@@ -9,8 +9,8 @@ export type * as ns from './a'; // Grammar error
 
 // @Filename: d.ts
 import { A } from './b';
-A; // Error
+A;
 
 // @Filename: e.ts
 import { ns } from './c';
-ns.A; // Error
+ns.A;