Skip to content

Commit acac035

Browse files
authored
Add missing index.ts files to user projects (#39163)
This makes the language service treat .js files inside node_modules as part of the parent project, so that you can view the same errors in the editor as you see in the baselines. Also update a comment in the parser that I missed in an earlier PR.
1 parent 2f79389 commit acac035

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

41 files changed

+242
-77
lines changed

src/compiler/parser.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -3527,7 +3527,7 @@ namespace ts {
35273527
type = finishNode(factory.createJSDocNonNullableType(type), pos);
35283528
break;
35293529
case SyntaxKind.QuestionToken:
3530-
// If not in JSDoc and next token is start of a type we have a conditional type
3530+
// If next token is start of a type we have a conditional type
35313531
if (lookAhead(nextTokenIsStartOfType)) {
35323532
return type;
35333533
}

tests/cases/user/acorn/index.ts

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
import x = require('acorn');

tests/cases/user/acorn/tsconfig.json

+12-4
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,16 @@
77
"noEmit": true,
88
"allowJs": true,
99
"checkJs": true,
10-
"types": ["node"],
11-
"lib": ["esnext", "dom"],
10+
"types": [
11+
"node"
12+
],
13+
"lib": [
14+
"esnext",
15+
"dom"
16+
]
1217
},
13-
"include": ["node_modules/acorn"]
14-
}
18+
"include": [
19+
"node_modules/acorn",
20+
"index.ts"
21+
]
22+
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
import x = require('adonis-framework/src/View');

tests/cases/user/adonis-framework/tsconfig.json

+12-4
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,16 @@
77
"noEmit": true,
88
"allowJs": true,
99
"checkJs": true,
10-
"types": ["node"],
11-
"lib": ["esnext", "dom"],
10+
"types": [
11+
"node"
12+
],
13+
"lib": [
14+
"esnext",
15+
"dom"
16+
]
1217
},
13-
"include": ["node_modules/adonis-framework"]
14-
}
18+
"include": [
19+
"node_modules/adonis-framework",
20+
"index.ts"
21+
]
22+
}

tests/cases/user/assert/index.ts

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
import x = require('assert');

tests/cases/user/assert/tsconfig.json

+12-4
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,16 @@
77
"noEmit": true,
88
"allowJs": true,
99
"checkJs": true,
10-
"types": ["node"],
11-
"lib": ["esnext", "dom"],
10+
"types": [
11+
"node"
12+
],
13+
"lib": [
14+
"esnext",
15+
"dom"
16+
]
1217
},
13-
"include": ["node_modules/assert"]
14-
}
18+
"include": [
19+
"node_modules/assert",
20+
"index.ts"
21+
]
22+
}

tests/cases/user/async/index.ts

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
import async_ = require('async');

tests/cases/user/async/tsconfig.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,5 @@
1010
"types": ["node"],
1111
"lib": ["esnext", "dom"],
1212
},
13-
"include": ["node_modules/async"]
13+
"include": ["index.ts", "node_modules/async"]
1414
}

tests/cases/user/bcryptjs/index.ts

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
import x = require('bcryptjs');

tests/cases/user/bcryptjs/tsconfig.json

+10-4
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,18 @@
77
"noEmit": true,
88
"allowJs": true,
99
"checkJs": true,
10-
"types": ["node"],
11-
"lib": ["esnext", "dom"],
10+
"types": [
11+
"node"
12+
],
13+
"lib": [
14+
"esnext",
15+
"dom"
16+
]
1217
},
1318
"include": [
1419
"node_modules/bcryptjs/scripts",
1520
"node_modules/bcryptjs/src",
16-
"node_modules/bcryptjs/tests"
21+
"node_modules/bcryptjs/tests",
22+
"index.ts"
1723
]
18-
}
24+
}

tests/cases/user/bluebird/index.ts

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
import x = require('bluebird');

tests/cases/user/bluebird/tsconfig.json

+12-4
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,16 @@
77
"noEmit": true,
88
"allowJs": true,
99
"checkJs": true,
10-
"types": ["node"],
11-
"lib": ["esnext", "dom"],
10+
"types": [
11+
"node"
12+
],
13+
"lib": [
14+
"esnext",
15+
"dom"
16+
]
1217
},
13-
"include": ["node_modules/bluebird/js/release"]
14-
}
18+
"include": [
19+
"node_modules/bluebird/js/release",
20+
"index.ts"
21+
]
22+
}
+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
import x = require('clear-require');

tests/cases/user/clear-require/tsconfig.json

+12-4
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,16 @@
77
"noEmit": true,
88
"allowJs": true,
99
"checkJs": true,
10-
"lib": ["esnext", "dom"],
11-
"types": ["node"]
10+
"lib": [
11+
"esnext",
12+
"dom"
13+
],
14+
"types": [
15+
"node"
16+
]
1217
},
13-
"include": ["node_modules/clear-require"]
14-
}
18+
"include": [
19+
"node_modules/clear-require",
20+
"index.ts"
21+
]
22+
}

tests/cases/user/clone/index.ts

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
import x = require('clone');

tests/cases/user/clone/tsconfig.json

+12-4
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,16 @@
77
"noEmit": true,
88
"allowJs": true,
99
"checkJs": true,
10-
"types": ["node"],
11-
"lib": ["esnext", "dom"],
10+
"types": [
11+
"node"
12+
],
13+
"lib": [
14+
"esnext",
15+
"dom"
16+
]
1217
},
13-
"include": ["node_modules/clone"]
14-
}
18+
"include": [
19+
"node_modules/clone",
20+
"index.ts"
21+
]
22+
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
import x = require('content-disposition');

tests/cases/user/content-disposition/tsconfig.json

+12-4
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,16 @@
77
"noEmit": true,
88
"allowJs": true,
99
"checkJs": true,
10-
"types": ["node"],
11-
"lib": ["esnext", "dom"],
10+
"types": [
11+
"node"
12+
],
13+
"lib": [
14+
"esnext",
15+
"dom"
16+
]
1217
},
13-
"include": ["node_modules/content-disposition"]
14-
}
18+
"include": [
19+
"node_modules/content-disposition",
20+
"index.ts"
21+
]
22+
}

tests/cases/user/debug/index.ts

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
import debug = require('debug');

tests/cases/user/debug/tsconfig.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,5 @@
1010
"types": ["node"],
1111
"lib": ["esnext", "dom"],
1212
},
13-
"include": ["node_modules/debug"]
13+
"include": ["index.ts", "node_modules/debug"]
1414
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
import x = require('enhanced-resolve');

tests/cases/user/enhanced-resolve/tsconfig.json

+13-5
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,18 @@
77
"noEmit": true,
88
"allowJs": true,
99
"checkJs": true,
10-
"types": ["node"],
11-
"lib": ["esnext", "dom"],
10+
"types": [
11+
"node"
12+
],
13+
"lib": [
14+
"esnext",
15+
"dom"
16+
],
1217
"module": "CommonJS",
13-
"target": "esnext",
18+
"target": "esnext"
1419
},
15-
"include": ["node_modules/enhanced-resolve"]
16-
}
20+
"include": [
21+
"node_modules/enhanced-resolve",
22+
"index.ts"
23+
]
24+
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
import x = require('follow-redirects');

tests/cases/user/follow-redirects/tsconfig.json

+12-4
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,16 @@
77
"noEmit": true,
88
"allowJs": true,
99
"checkJs": true,
10-
"types": ["node"],
11-
"lib": ["esnext", "dom"],
10+
"types": [
11+
"node"
12+
],
13+
"lib": [
14+
"esnext",
15+
"dom"
16+
]
1217
},
13-
"include": ["node_modules/follow-redirects"]
14-
}
18+
"include": [
19+
"node_modules/follow-redirects",
20+
"index.ts"
21+
]
22+
}

tests/cases/user/graceful-fs/index.ts

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
import x = require('graceful-fs');

tests/cases/user/graceful-fs/tsconfig.json

+12-4
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,16 @@
77
"noEmit": true,
88
"allowJs": true,
99
"checkJs": true,
10-
"types": ["node"],
11-
"lib": ["esnext", "dom"],
10+
"types": [
11+
"node"
12+
],
13+
"lib": [
14+
"esnext",
15+
"dom"
16+
]
1217
},
13-
"include": ["node_modules/graceful-fs"]
14-
}
18+
"include": [
19+
"node_modules/graceful-fs",
20+
"index.ts"
21+
]
22+
}

tests/cases/user/lodash/index.ts

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
import x = require('lodash');

tests/cases/user/lodash/tsconfig.json

+15-5
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,19 @@
77
"noEmit": true,
88
"allowJs": true,
99
"checkJs": true,
10-
"types": ["node"],
11-
"lib": ["esnext", "dom"],
10+
"types": [
11+
"node"
12+
],
13+
"lib": [
14+
"esnext",
15+
"dom"
16+
]
1217
},
13-
"include": ["node_modules/lodash"],
14-
"exclude": ["node_modules/lodash/lodash.js"]
15-
}
18+
"include": [
19+
"node_modules/lodash",
20+
"index.ts"
21+
],
22+
"exclude": [
23+
"node_modules/lodash/lodash.js"
24+
]
25+
}

tests/cases/user/minimatch/index.ts

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
import x = require('minimatch');

tests/cases/user/minimatch/tsconfig.json

+12-4
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,16 @@
77
"noEmit": true,
88
"allowJs": true,
99
"checkJs": true,
10-
"types": ["node"],
11-
"lib": ["esnext", "dom"],
10+
"types": [
11+
"node"
12+
],
13+
"lib": [
14+
"esnext",
15+
"dom"
16+
]
1217
},
13-
"include": ["node_modules/minimatch"]
14-
}
18+
"include": [
19+
"node_modules/minimatch",
20+
"index.ts"
21+
]
22+
}

tests/cases/user/npm/index.ts

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
import x = require('npm');

tests/cases/user/npm/tsconfig.json

+13-4
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,17 @@
77
"noEmit": true,
88
"allowJs": true,
99
"checkJs": true,
10-
"types": ["node"],
11-
"lib": ["esnext", "dom", "scripthost"],
10+
"types": [
11+
"node"
12+
],
13+
"lib": [
14+
"esnext",
15+
"dom",
16+
"scripthost"
17+
]
1218
},
13-
"include": ["node_modules/npm"]
14-
}
19+
"include": [
20+
"node_modules/npm",
21+
"index.ts"
22+
]
23+
}

tests/cases/user/npmlog/index.ts

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
import x = require('npmlog');

0 commit comments

Comments
 (0)