Skip to content

Variable declared after use in generated code #15410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tsvetomir opened this issue Apr 27, 2017 · 4 comments
Closed

Variable declared after use in generated code #15410

tsvetomir opened this issue Apr 27, 2017 · 4 comments
Labels
Duplicate An existing issue was already created

Comments

@tsvetomir
Copy link

TypeScript Version: 2.2.2

Code

function foo() {
    const key = 'bar';

    return {
        [key || 'baz']: true
    }
}

Expected behavior:

function foo() {
    var key = 'bar';
    var _a;
    return _a = {},
        _a[key || 'baz'] = true,
        _a;
}

Actual behavior:

function foo() {
    var key = 'bar';
    return _a = {},
        _a[key || 'baz'] = true,
        _a;
    var _a;
}
@tsvetomir
Copy link
Author

Note that the generated code is actually correct as _a is hoisted to the function scope.
The problem is that minifiers such as UglifyJS will complain about it as it follows a return statement.

Dropping unreachable code
Declarations in unreachable code!

@fatcerberus
Copy link

This is a known issue - see #4138.

@RyanCavanaugh RyanCavanaugh added the Duplicate An existing issue was already created label Apr 27, 2017
@tsvetomir
Copy link
Author

Thanks! The original issue is closed, should we keep this one or reopen it instead?

@mhegazy
Copy link
Contributor

mhegazy commented May 22, 2017

Automatically closing this issue for housekeeping purposes. The issue labels indicate that it is unactionable at the moment or has already been addressed.

@mhegazy mhegazy closed this as completed May 22, 2017
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Duplicate An existing issue was already created
Projects
None yet
Development

No branches or pull requests

4 participants