Skip to content

"convert to a ES6 module" code action doesn't preserve type of quotes #22921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mjbvz opened this issue Mar 27, 2018 · 1 comment
Closed

"convert to a ES6 module" code action doesn't preserve type of quotes #22921

mjbvz opened this issue Mar 27, 2018 · 1 comment
Labels
Bug A bug in TypeScript Domain: Refactorings e.g. extract to constant or function, rename symbol Fixed A PR has been merged for this issue

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Mar 27, 2018

microsoft/vscode#46679

TypeScript Version: 2.9.0-dev.20180327

Search Terms:

  • Quick fix
  • code action
  • convert to es6 module

Code
For the js:

var path = require('path');

Run the Convert to es6 module code action

Expected behavior:
Quote style unchanged after conversion:

import path from 'path';

Actual behavior:
Quote style changed:

import path from "path";
@mjbvz
Copy link
Contributor Author

mjbvz commented Mar 27, 2018

Probably should fall under #20619

@mhegazy mhegazy added Bug A bug in TypeScript Domain: Refactorings e.g. extract to constant or function, rename symbol labels Mar 27, 2018
@mhegazy mhegazy assigned ghost Mar 27, 2018
@mhegazy mhegazy added this to the TypeScript 2.9 milestone Mar 27, 2018
@ghost ghost closed this as completed in #22929 Mar 28, 2018
@ghost ghost added the Fixed A PR has been merged for this issue label Mar 28, 2018
@microsoft microsoft locked and limited conversation to collaborators Jul 25, 2018
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript Domain: Refactorings e.g. extract to constant or function, rename symbol Fixed A PR has been merged for this issue
Projects
None yet
Development

No branches or pull requests

2 participants