Skip to content

Jsdoc error at jakefile #25657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
j-oliveras opened this issue Jul 13, 2018 · 2 comments
Closed

Jsdoc error at jakefile #25657

j-oliveras opened this issue Jul 13, 2018 · 2 comments
Labels
Help Wanted You can do this Infrastructure Issue relates to TypeScript team infrastructure

Comments

@j-oliveras
Copy link
Contributor

While doing #25656 I see that jakefile has an error at https://github.com/Microsoft/TypeScript/blob/47e513e1517b4d7e96c4a31448189fea4d9534ab/Jakefile.js#L504
because that function has three needed parameters. See jsdoc at implementation (the third is not optional):
https://github.com/Microsoft/TypeScript/blob/47e513e1517b4d7e96c4a31448189fea4d9534ab/Jakefile.js#L816-L839

The implementation treats the third parameter as optional, but the only call to this function don't use it.
Is better remove the third parameter or make it optional?

CC @RyanCavanaugh since you changed this code the last time.

@mhegazy
Copy link
Contributor

mhegazy commented Jul 16, 2018

extraContent should be optional. thanks!

@mhegazy mhegazy added Infrastructure Issue relates to TypeScript team infrastructure Help Wanted You can do this labels Jul 16, 2018
@mhegazy mhegazy added this to the Community milestone Jul 16, 2018
@mhegazy mhegazy modified the milestones: Community, TypeScript 3.1 Jul 17, 2018
@mhegazy
Copy link
Contributor

mhegazy commented Jul 17, 2018

thanks @j-oliveras !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted You can do this Infrastructure Issue relates to TypeScript team infrastructure
Projects
None yet
Development

No branches or pull requests

2 participants