Skip to content

TypeFlags outside small integer range #28354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ahejlsberg opened this issue Nov 6, 2018 · 2 comments
Closed

TypeFlags outside small integer range #28354

ahejlsberg opened this issue Nov 6, 2018 · 2 comments
Assignees
Labels
Bug A bug in TypeScript High Priority

Comments

@ahejlsberg
Copy link
Member

In #25886 two extra TypeFlags were introduced and we're now using 32 bits. That's bad! Anything beyond the lower 30 bits (1 << 29) causes numbers to be boxed and positively wreaks havoc on performance. We know this first hand from previous overflows. We need to bring TypeFlags back down to 30 bits ASAP, and certainly before we ship the next RC or release. I'm surprised we merged the PR with this known issue (e.g. see here).

@ahejlsberg
Copy link
Member Author

@sheetalkamat I'm already working on a fix for this.

@sheetalkamat
Copy link
Member

Ok thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in TypeScript High Priority
Projects
None yet
Development

No branches or pull requests

2 participants