Skip to content

Javascript, Nodejs: Go to definition for required file does not work if required file does not contain exports. #29292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Dzenly opened this issue Jan 7, 2019 · 0 comments
Open

Javascript, Nodejs: Go to definition for required file does not work if required file does not contain exports. #29292

Dzenly opened this issue Jan 7, 2019 · 0 comments
Labels
Bug A bug in TypeScript Domain: Symbol Navigation Relates to go-to-definition, find-all-references, highlighting/occurrences. Domain: TSServer Issues related to the TSServer
Milestone
Backlog

Comments

@Dzenly
Copy link

Dzenly commented Jan 7, 2019

a.js

require('./b.js'); // Go to definion does not work here. But 'Find all references' does work.
require('./c.js'); // Go to definion works here.

b.js

// no exports or module.exports assigns here, just some side effects.

c.js

exports.a = 42;

VSCode 1.30.1.
Linux 4.18 x64..

Does this issue occur when all extensions are disabled?: Yes/No

Yes.
@vscodebot vscodebot bot assigned mjbvz Jan 7, 2019
@mjbvz mjbvz transferred this issue from microsoft/vscode Jan 7, 2019
@mjbvz mjbvz removed their assignment Jan 7, 2019
@weswigham weswigham added Bug A bug in TypeScript Domain: TSServer Issues related to the TSServer labels Jan 8, 2019
@csnv csnv mentioned this issue Feb 4, 2019
Closed
@RyanCavanaugh RyanCavanaugh added this to the Backlog milestone Mar 14, 2019
@DanielRosenwasser DanielRosenwasser added the Domain: Symbol Navigation Relates to go-to-definition, find-all-references, highlighting/occurrences. label Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug A bug in TypeScript Domain: Symbol Navigation Relates to go-to-definition, find-all-references, highlighting/occurrences. Domain: TSServer Issues related to the TSServer
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
6 participants
@DanielRosenwasser @weswigham @RyanCavanaugh @Dzenly @mjbvz and others