Skip to content

lib.dom.d.ts contains interface Account #42440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Aprillion opened this issue Jan 21, 2021 · 4 comments
Closed

lib.dom.d.ts contains interface Account #42440

Aprillion opened this issue Jan 21, 2021 · 4 comments
Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Help Wanted You can do this
Milestone

Comments

@Aprillion
Copy link

Bug Report

🔎 Search Terms

https://github.com/microsoft/TypeScript/issues?q=is%3Aissue+is%3Aopen+lib.dom.d.ts+Account
Following issues seem related, but none suggests removal of the Account interface: #32845, #19040, #23595

🕗 Version & Regression Information

?

⏯ Playground Link

N/A

💻 Code

interface Account {
displayName: string;
id: string;
imageURL?: string;
name?: string;
rpDisplayName: string;
}

🙁 Actual behavior

interface Account is present in lib.dom.d.ts without an explanation in comment or git commit message.

🙂 Expected behavior

There is no real DOM API with such interface => should be either removed or explained with a comment.

Maybe it was created by webscraping MDN? https://developer.mozilla.org/en-US/account/ page exists and it displays info similar to the interface for logged in users ¯\_(ツ)_/¯

@MartinJohns
Copy link
Contributor

It's just really really outdated: https://www.w3.org/TR/2016/WD-webauthn-20160531/

@Aprillion
Copy link
Author

Aprillion commented Jan 21, 2021

I just found following statement in a closed issue:

Account is part of the Web Authentication DOM APIs (though it is still experimental). if you are not interested in DOM, consider using --lib es2015 this will get you the JS standard library for es2015 without the DOM.

Originally posted by @mhegazy in #22057 (comment)

But none of the Interfaces in https://developer.mozilla.org/en-US/docs/Web/API/Web_Authentication_API has the same shape as Account from TypeScript, so I am confused about that...

Edit:

It's just really really outdated: https://www.w3.org/TR/2016/WD-webauthn-20160531/

Oh, ok.

@RyanCavanaugh RyanCavanaugh added Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Help Wanted You can do this labels Jan 21, 2021
@RyanCavanaugh RyanCavanaugh added this to the Backlog milestone Jan 21, 2021
@AviVahl
Copy link

AviVahl commented Jan 21, 2021

microsoft/TypeScript-DOM-lib-generator#931

@jakebailey
Copy link
Member

This was fixed in #43070.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Help Wanted You can do this
Projects
None yet
Development

No branches or pull requests

5 participants