Skip to content

@see links in JSDoc comments are broken by VSCode #43803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ImRodry opened this issue Apr 21, 2021 · 7 comments
Closed

@see links in JSDoc comments are broken by VSCode #43803

ImRodry opened this issue Apr 21, 2021 · 7 comments

Comments

@ImRodry
Copy link

ImRodry commented Apr 21, 2021

TS Template added by @mjbvz

TypeScript Version: 4.3.0-dev.20210420

Search Terms

  • quick info
  • IntelliSense

Issue Type: Bug

When you have a JSDoc comment with an @see line above a function or type and you hover over said function or type, the link will be automatically split after https, making it impossible to Ctrl + click to go to the linked website. The link should display like this: https ://

Example:
image
image

VS Code version: Code 1.55.2 (3c4e3df9e89829dce27b7b5c24508306b151f30d, 2021-04-13T09:35:57.887Z)
OS version: Windows_NT x64 10.0.19042

System Info
Item Value
CPUs Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz (12 x 3192)
GPU Status 2d_canvas: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: enabled_on
video_decode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 19.89GB (10.13GB free)
Process Argv D:\Users\rodri\Documents\GitHub\hypixel-translators-bot --crash-reporter-id 1aa51578-c79e-468f-b062-c24334e21918
Screen Reader no
VM 0%
Extensions (23)
Extension Author (truncated) Version
gitlens eam 11.4.1
EditorConfig Edi 0.16.4
prettier-vscode esb 6.3.2
vscode-lombok Gab 1.0.1
vscode-graphql Gra 0.3.15
discord-vscode icr 5.6.3
vscode-env Iro 0.1.0
csharp ms- 1.23.11
python ms- 2021.4.765268190
jupyter ms- 2021.5.745244803
vsliveshare ms- 1.0.4131
vsliveshare-pack ms- 0.4.0
gradle-language nac 0.2.3
vetur oct 0.33.1
java red 0.77.0
vscode-yaml red 0.18.0
vscodeintellicode Vis 1.2.12
vscode-java-debug vsc 0.32.1
vscode-java-dependency vsc 0.18.3
vscode-java-pack vsc 0.14.0
vscode-java-test vsc 0.28.1
vscode-maven vsc 0.29.0
minecraft-lang-colorizer zz5 1.0.0
A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
vspyt653:30270858
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstry244:30276681
pythonvsdeb440:30248342
pythonvsded773:30248341
pythonvspyt875:30259475
pythonvsnew554cf:30291488
pythontb:30283811
vspre833cf:30267465
pythonptprofiler:30281270
vshan820cf:30276953
pythondataviewer:30285071
vscus158cf:30286554

@vscodebot
Copy link

vscodebot bot commented Apr 21, 2021

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@ImRodry
Copy link
Author

ImRodry commented Apr 21, 2021

Not a duplicate of neither of those.

@mjbvz mjbvz transferred this issue from microsoft/vscode Apr 24, 2021
@mjbvz mjbvz removed their assignment Apr 24, 2021
@mjbvz
Copy link
Contributor

mjbvz commented Apr 24, 2021

@sandersn Looks like @see https://example.com is being broken into:

 "name": "see",
            "text": [
                {
                    "text": "https",
                    "kind": "text"
                },
                {
                    "text": " ",
                    "kind": "space"
                },
                {
                    "text": "://example.com",
                    "kind": "text"
                }
            ]

@sandersn
Copy link
Member

should be fixed by #43800

@ImRodry
Copy link
Author

ImRodry commented Apr 24, 2021

Is there a way for me to test before the next release is out?

@sandersn
Copy link
Member

@ImRodry maybe this extension? https://marketplace.visualstudio.com/items?itemName=ms-vscode.vscode-typescript-next

I don't use this but I think @mjbvz made it so if I'm right he'll know more.

@ImRodry
Copy link
Author

ImRodry commented Apr 26, 2021

Oh I had seen that extension and installed it but forgot to restart vscode when I installed it. The issue is indeed fixed so I'll close this. Thank you!

@ImRodry ImRodry closed this as completed Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants