Skip to content

Provide more information when module resolution fails but a '.js' file was found #5146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DanielRosenwasser opened this issue Oct 7, 2015 · 2 comments
Closed

Provide more information when module resolution fails but a '.js' file was found #5146

DanielRosenwasser opened this issue Oct 7, 2015 · 2 comments
Labels
In Discussion Not yet reached consensus Suggestion An idea for TypeScript

Comments

@DanielRosenwasser
Copy link
Member

If a .js file was found in performing module resolution, we should inform the user that they are missing a declaration file.
@DanielRosenwasser DanielRosenwasser added Suggestion An idea for TypeScript Needs More Info The issue still hasn't been fully clarified Needs Proposal This issue needs a plan that clarifies the finer details of how it could be implemented. and removed Needs More Info The issue still hasn't been fully clarified labels Oct 7, 2015
@BretJohnson
Copy link

+1 on this. As a semi-noob I can attest that with all the vagaries around module loading logic, the more hints we can give the user about what's wrong (and what they may need to do to fix it) the better.
I also wrote up #5149, which is related.

@mhegazy mhegazy added In Discussion Not yet reached consensus and removed Needs Proposal This issue needs a plan that clarifies the finer details of how it could be implemented. labels Feb 22, 2016
@RyanCavanaugh
Copy link
Member

We have this now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
In Discussion Not yet reached consensus Suggestion An idea for TypeScript
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@BretJohnson @DanielRosenwasser @RyanCavanaugh @mhegazy