Skip to content

Rename Symbol goes to undesired places #9119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dbaeumer opened this issue Jun 13, 2016 · 2 comments
Closed

Rename Symbol goes to undesired places #9119

dbaeumer opened this issue Jun 13, 2016 · 2 comments
Labels
Duplicate An existing issue was already created

Comments

@dbaeumer
Copy link
Member

From @Spown on June 9, 2016 14:18

  • VSCode Version: 1.2.0
  • OS Version: Win10x64

Rename Symbol can wander off into files, that are undesired to change. Just now I had several lines using __dirname global variable, I decided to use an another user defined variable settings.paths.root and used Rename Symbol it worked fine, except it also went into .\typings\node\node.d.ts and changed it there as well... This happens even if I exclude the typings dir in .vscode\settings.json

Copied from original issue: microsoft/vscode#7478
@dbaeumer
Copy link
Member Author

Rename operation is provided by the TS server. Moving...

@dbaeumer dbaeumer mentioned this issue Jun 13, 2016
Closed
@mhegazy
Copy link
Contributor

mhegazy commented Jun 13, 2016

closing in favor of #8227

@mhegazy mhegazy closed this as completed Jun 13, 2016
@mhegazy mhegazy added the Duplicate An existing issue was already created label Jun 13, 2016
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Duplicate An existing issue was already created
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dbaeumer @mhegazy