Skip to content

Remove unneeded Array and Promise JS rewrites #35482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2019

Conversation

sandersn
Copy link
Member

@sandersn sandersn commented Dec 3, 2019

Type-argument defaulting is handled elsewhere in the compiler. This is a small drive-by improvement, so I didn't change the handling of 'array' or 'promise'; they still manually create any[] and Promise<any>, respectively.

Type-argument defaulting is handled elsewhere in the compiler.
This is a small drive-by improvement, so I didn't change the handling of
'array' or 'promise'; they still manually create `any[]` and
`Promise<any>`, respectively.
@sandersn sandersn requested a review from elibarzilay December 3, 2019 23:45
Copy link
Contributor

@elibarzilay elibarzilay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(BTW: where is the other place where they are defined?)

@sandersn
Copy link
Member Author

sandersn commented Dec 4, 2019

getEffectiveTypeArguments and fillMissingTypeArguments. Array and Promise are globalArrayType and globalPromiseType, respectively.

@sandersn sandersn merged commit a816162 into master Dec 4, 2019
@sandersn sandersn deleted the remove-unneeded-intended-type-rewrites branch December 4, 2019 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants