From ea54e21ac46d0068300dde41c1c6f401755d7f9c Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Fri, 13 May 2022 09:51:59 +0300 Subject: [PATCH] fix confused comment --- .../reference/jsxExcessPropsAndAssignability.errors.txt | 8 +++----- .../baselines/reference/jsxExcessPropsAndAssignability.js | 4 ---- .../reference/jsxExcessPropsAndAssignability.symbols | 6 ++---- .../reference/jsxExcessPropsAndAssignability.types | 4 +--- tests/cases/compiler/jsxExcessPropsAndAssignability.tsx | 2 -- 5 files changed, 6 insertions(+), 18 deletions(-) diff --git a/tests/baselines/reference/jsxExcessPropsAndAssignability.errors.txt b/tests/baselines/reference/jsxExcessPropsAndAssignability.errors.txt index 3e15a705edf6c..dfe61765e395d 100644 --- a/tests/baselines/reference/jsxExcessPropsAndAssignability.errors.txt +++ b/tests/baselines/reference/jsxExcessPropsAndAssignability.errors.txt @@ -1,7 +1,7 @@ -tests/cases/compiler/jsxExcessPropsAndAssignability.tsx(14,27): error TS2698: Spread types may only be created from object types. -tests/cases/compiler/jsxExcessPropsAndAssignability.tsx(16,6): error TS2322: Type 'ComposedComponentProps & { myProp: number; }' is not assignable to type 'IntrinsicAttributes & IntrinsicClassAttributes> & Readonly<{ children?: ReactNode; }> & Readonly'. +tests/cases/compiler/jsxExcessPropsAndAssignability.tsx(13,27): error TS2698: Spread types may only be created from object types. +tests/cases/compiler/jsxExcessPropsAndAssignability.tsx(14,6): error TS2322: Type 'ComposedComponentProps & { myProp: number; }' is not assignable to type 'IntrinsicAttributes & IntrinsicClassAttributes> & Readonly<{ children?: ReactNode; }> & Readonly'. Type 'ComposedComponentProps & { myProp: number; }' is not assignable to type 'Readonly'. -tests/cases/compiler/jsxExcessPropsAndAssignability.tsx(16,27): error TS2698: Spread types may only be created from object types. +tests/cases/compiler/jsxExcessPropsAndAssignability.tsx(14,27): error TS2698: Spread types may only be created from object types. ==== tests/cases/compiler/jsxExcessPropsAndAssignability.tsx (3 errors) ==== @@ -17,11 +17,9 @@ tests/cases/compiler/jsxExcessPropsAndAssignability.tsx(16,27): error TS2698: Sp const props: ComposedComponentProps = null as any; - // Expected no error, got none - good ; ~~~~~ !!! error TS2698: Spread types may only be created from object types. - // Expected error, but got none - bad! ; ~~~~~~~~~~~~~~~~ !!! error TS2322: Type 'ComposedComponentProps & { myProp: number; }' is not assignable to type 'IntrinsicAttributes & IntrinsicClassAttributes> & Readonly<{ children?: ReactNode; }> & Readonly'. diff --git a/tests/baselines/reference/jsxExcessPropsAndAssignability.js b/tests/baselines/reference/jsxExcessPropsAndAssignability.js index 68e02b91877a8..eeeb82b1ab1f1 100644 --- a/tests/baselines/reference/jsxExcessPropsAndAssignability.js +++ b/tests/baselines/reference/jsxExcessPropsAndAssignability.js @@ -11,9 +11,7 @@ const myHoc = ( const props: ComposedComponentProps = null as any; - // Expected no error, got none - good ; - // Expected error, but got none - bad! ; }; @@ -37,8 +35,6 @@ var React = require("react"); var myHoc = function (ComposedComponent) { var WrapperComponent = null; var props = null; - // Expected no error, got none - good React.createElement(WrapperComponent, __assign({}, props, { myProp: '1000000' })); - // Expected error, but got none - bad! React.createElement(WrapperComponent, __assign({}, props, { myProp: 1000000 })); }; diff --git a/tests/baselines/reference/jsxExcessPropsAndAssignability.symbols b/tests/baselines/reference/jsxExcessPropsAndAssignability.symbols index fa5e712abe6a6..b5ebf5ef4878e 100644 --- a/tests/baselines/reference/jsxExcessPropsAndAssignability.symbols +++ b/tests/baselines/reference/jsxExcessPropsAndAssignability.symbols @@ -30,17 +30,15 @@ const myHoc = ( >props : Symbol(props, Decl(jsxExcessPropsAndAssignability.tsx, 10, 9)) >ComposedComponentProps : Symbol(ComposedComponentProps, Decl(jsxExcessPropsAndAssignability.tsx, 4, 15)) - // Expected no error, got none - good ; >WrapperComponent : Symbol(WrapperComponent, Decl(jsxExcessPropsAndAssignability.tsx, 8, 9)) >props : Symbol(props, Decl(jsxExcessPropsAndAssignability.tsx, 10, 9)) ->myProp : Symbol(myProp, Decl(jsxExcessPropsAndAssignability.tsx, 13, 32)) +>myProp : Symbol(myProp, Decl(jsxExcessPropsAndAssignability.tsx, 12, 32)) - // Expected error, but got none - bad! ; >WrapperComponent : Symbol(WrapperComponent, Decl(jsxExcessPropsAndAssignability.tsx, 8, 9)) >props : Symbol(props, Decl(jsxExcessPropsAndAssignability.tsx, 10, 9)) ->myProp : Symbol(myProp, Decl(jsxExcessPropsAndAssignability.tsx, 15, 32)) +>myProp : Symbol(myProp, Decl(jsxExcessPropsAndAssignability.tsx, 13, 32)) }; diff --git a/tests/baselines/reference/jsxExcessPropsAndAssignability.types b/tests/baselines/reference/jsxExcessPropsAndAssignability.types index c9fa90a0c6903..b0c77ff1be2ad 100644 --- a/tests/baselines/reference/jsxExcessPropsAndAssignability.types +++ b/tests/baselines/reference/jsxExcessPropsAndAssignability.types @@ -6,7 +6,7 @@ import * as React from 'react'; const myHoc = ( >myHoc : (ComposedComponent: React.ComponentClass) => void ->( ComposedComponent: React.ComponentClass,) => { type WrapperComponentProps = ComposedComponentProps & { myProp: string }; const WrapperComponent: React.ComponentClass = null as any; const props: ComposedComponentProps = null as any; // Expected no error, got none - good ; // Expected error, but got none - bad! ;} : (ComposedComponent: React.ComponentClass) => void +>( ComposedComponent: React.ComponentClass,) => { type WrapperComponentProps = ComposedComponentProps & { myProp: string }; const WrapperComponent: React.ComponentClass = null as any; const props: ComposedComponentProps = null as any; ; ;} : (ComposedComponent: React.ComponentClass) => void ComposedComponent: React.ComponentClass, >ComposedComponent : React.ComponentClass @@ -28,7 +28,6 @@ const myHoc = ( >null as any : any >null : null - // Expected no error, got none - good ; > : JSX.Element >WrapperComponent : React.ComponentClass @@ -36,7 +35,6 @@ const myHoc = ( >myProp : "1000000" >'1000000' : "1000000" - // Expected error, but got none - bad! ; > : JSX.Element >WrapperComponent : React.ComponentClass diff --git a/tests/cases/compiler/jsxExcessPropsAndAssignability.tsx b/tests/cases/compiler/jsxExcessPropsAndAssignability.tsx index e2437360ed1ce..e5c56b222fd08 100644 --- a/tests/cases/compiler/jsxExcessPropsAndAssignability.tsx +++ b/tests/cases/compiler/jsxExcessPropsAndAssignability.tsx @@ -12,8 +12,6 @@ const myHoc = ( const props: ComposedComponentProps = null as any; - // Expected no error, got none - good ; - // Expected error, but got none - bad! ; };